add contextlib.chdir #6191
Merged
add contextlib.chdir #6191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Akuli
reviewed
Oct 23, 2021
Co-authored-by: Akuli <akuviljanen17@gmail.com>
Collaborator
|
It might be a bit early because 3.11 can still change, but we can always change this later. I would like to know what other maintainers think. |
Akuli
reviewed
Oct 23, 2021
This comment has been minimized.
This comment has been minimized.
Collaborator
|
I'm fine with adding 3.11 annotations, especially ones that are not likely to change. Less chance to forget them later. |
Akuli
reviewed
Oct 23, 2021
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Akuli <akuviljanen17@gmail.com>
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
Akuli
reviewed
Oct 23, 2021
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
graingert
commented
Nov 8, 2021
JelleZijlstra
approved these changes
Nov 8, 2021
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Akuli
approved these changes
Nov 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see python/cpython#28271
Is it too early to start adding 3.11 types to typeshed? I'm looking to add it here so I can backport the types cleanly into contextlib2