Correct add parameter for tkinter.Misc.bind() function
#6337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documentation[1] for the `bind()` method in tkinter states that the `add` parameter is a string argument. Previously the type-hints had it as a boolean. The implementation[2] actually supports either a bool or a str (or any "truthy") value. 1. https://docs.python.org/3/library/tkinter.html#bindings-and-events 2. https://github.com/python/cpython/blob/32959108f9c543e3cb9f2b68bbc782bddded6f42/Lib/tkinter/__init__.py#L1372 Fixes #6332
Contributor
Author
|
Never mind. I see #6334 has already been proposed. |
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Member
|
@JohnVillalovos sorry for stealing your issue 🙂 |
Contributor
Author
No worries. Actually thank you for doing it! Much appreciated 👍😊 |
Contributor
Author
|
I guess I should actually say спасибо @sobolevn 😊 |
Member
|
Oh wow! Do you happen to know Russian? 😮 😊 |
Contributor
Author
Only a little. (my-lin-kee ???) 😟 My wife is Russian 👍 So privyet Nikita! |
Member
|
Awesome! Great coincidence 👋 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation[1] for the
bind()method in tkinter states that theaddparameter is a string argument.Previously the type-hints had it as a boolean. The implementation[2]
actually supports either a bool or a str (or any "truthy") value.
Fixes #6332