Skip to content

Conversation

@elazarg
Copy link
Contributor

@elazarg elazarg commented Oct 29, 2016

This works with mypy/#2381, and seems to be appropriate, since this isn't a classmethod.

(As usual, irrelevant commits crept in. Please ignore)

I guess these kind of changes will happen frequently in the near future, while we learn how to use selftype.

@gvanrossum gvanrossum merged commit 7a623f2 into python:master Oct 30, 2016
@gvanrossum
Copy link
Member

I hope you will also learn to use git. :-) I think if you use rebase instead of merge when syncing up with upstream your local commits will look cleaner. (You may have to use git push -f but that's okay for private branches and PRs.) Occasionally git commit --amend is also handy.

hswong3i pushed a commit to alvistack/python-typeshed that referenced this pull request May 25, 2025
This covers python 3.53 and above. I added a fair amount of tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants