Skip to content

Clarify why csv stub has no __version__ attribute #6398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Akuli merged 4 commits into from
Nov 27, 2021
Merged

Clarify why csv stub has no __version__ attribute #6398

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3bc363a
Add missing `__version__` attribute to `csv.pyi`
AlexWaygood Nov 27, 2021
9dc2a75
Revert changes
AlexWaygood Nov 27, 2021
4b9b415
Add useful explanatory comments
AlexWaygood Nov 27, 2021
6ff28a3
Update stdlib/_csv.pyi
AlexWaygood Nov 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions stdlib/_csv.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
from typing import Any, Iterable, Iterator, List, Protocol, Type, Union

# __version__ is deliberately not defined here or in csv.pyi,
# as it appears to have been hardcoded at "1.0" for a very long time!

QUOTE_ALL: int
QUOTE_MINIMAL: int
QUOTE_NONE: int
Expand Down
3 changes: 3 additions & 0 deletions stdlib/csv.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@ if sys.version_info >= (3, 8):
else:
from collections import OrderedDict as _DictReadMapping

# __version__ is deliberately not defined here or in _csv.pyi,
# as it appears to have been hardcoded at "1.0" for a very long time!

_T = TypeVar("_T")

class excel(Dialect):
Expand Down