Flatten stubtest_allowlist for protobuf generated files #6944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added stubtest testing for generated files within mypy-protobuf. There are many ways in which the protobuf code is doing *weird* things and we want the stubs to look a bit different. They're enumerated in the `stubtest_allowlist.txt` of mypy-protobuf, so squashing them here so that this one can focus on the non-generated files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added stubtest testing for generated files within mypy-protobuf.
There are many ways in which the protobuf code is doing weird
things and we want the stubs to look a bit different. They're enumerated
in the
stubtest_allowlist.txtof mypy-protobuf, so squashing them hereso that this one can focus on the non-generated files.