Skip to content

Use _typeshed.Self in protobuf/google/protobuf/message.pyi #6955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hauntsaninja merged 2 commits into from
Jan 18, 2022
Merged

Use _typeshed.Self in protobuf/google/protobuf/message.pyi #6955

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f3d2e8a
Use `_typeshed.Self` in `protobuf/google/protobuf/message.pyi`
AlexWaygood Jan 18, 2022
553d38a
Fix
AlexWaygood Jan 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions stubs/protobuf/google/protobuf/message.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
from _typeshed import Self
from typing import Any, Sequence, TypeVar

from .descriptor import Descriptor, FieldDescriptor
Expand All @@ -14,8 +15,8 @@ class Message:
def __deepcopy__(self, memo=...): ...
def __eq__(self, other_msg): ...
def __ne__(self, other_msg): ...
def MergeFrom(self: _M, other_msg: _M) -> None: ...
def CopyFrom(self: _M, other_msg: _M) -> None: ...
def MergeFrom(self: Self, other_msg: Self) -> None: ...
def CopyFrom(self: Self, other_msg: Self) -> None: ...
def Clear(self) -> None: ...
def SetInParent(self) -> None: ...
def IsInitialized(self) -> bool: ...
Expand All @@ -24,11 +25,13 @@ class Message:
def SerializeToString(self, deterministic: bool = ...) -> bytes: ...
def SerializePartialToString(self, deterministic: bool = ...) -> bytes: ...
def ListFields(self) -> Sequence[tuple[FieldDescriptor, Any]]: ...
# The TypeVar must be bound to `Message` or we get mypy errors, so we cannot use `Self` for `HasExtension` & `ClearExtension`
def HasExtension(self: _M, extension_handle: _ExtensionFieldDescriptor[_M, Any]) -> bool: ...
def ClearExtension(self: _M, extension_handle: _ExtensionFieldDescriptor[_M, Any]) -> None: ...
def ByteSize(self) -> int: ...
@classmethod
def FromString(cls: type[_M], s: bytes) -> _M: ...
def FromString(cls: type[Self], s: bytes) -> Self: ...
# The TypeVar must be bound to `Message` or we get mypy errors, so we cannot use `Self` for `Extensions`
@property
def Extensions(self: _M) -> _ExtensionDict[_M]: ...
# Intentionally left out typing on these three methods, because they are
Expand Down