random: add new default args in py311 #7400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Akuli
approved these changes
Feb 28, 2022
|
|
||
| else: | ||
| def gauss(mu: float, sigma: float) -> float: ... | ||
| def normalvariate(mu: float, sigma: float) -> float: ... |
Collaborator
There was a problem hiding this comment.
I wonder if replacing these with pkg_resources.WorkingSet style aliases would be possible, to better match to runtime.
Collaborator
Author
There was a problem hiding this comment.
Good point, we should do that. I think for a long time pytype did not support bound methods, but now it does.
Collaborator
Author
There was a problem hiding this comment.
Yup, seems like we should be able to do this now: #4817 (comment)
hauntsaninja
pushed a commit
to hauntsaninja/typeshed
that referenced
this pull request
Mar 1, 2022
Suggested by Akuli in python#7400 Matches runtime better and minimises duplicated definitions. pytype only added support for bound methods about a year ago. We use them in a couple other places, e.g. multiprocessing and pkg_resources
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added in bpo-46737