mypy_extensions: fix TypeVar usage
#7937
Conversation
| @overload | ||
| def Arg(type: _T, name: str | None = ...) -> _T: ... | ||
| @overload | ||
| def Arg(name: str | None = ...) -> Any: ... |
There was a problem hiding this comment.
Shouldn't this be keyword-only?
Also we should make sure that mypy still works with this change, it may special-case the definitions here.
There was a problem hiding this comment.
Also we should make sure that mypy still works with this change, it may special-case the definitions here.
I was hoping primer would answer that question for me :)
There was a problem hiding this comment.
Not sure anyone in primer uses these things though.
There was a problem hiding this comment.
I'm going to try running the mypy test suite using MYPYPATH to point at the stubs with this revision.
There was a problem hiding this comment.
I think mypy won't like trying to use MYPYPATH for mypy_extensions (or maybe might ignore it). You're probably better off replacing mypy/typeshed/stubs/mypy-extensions/mypy_extensions.pyi. But also I'm happy to yolo this.
There was a problem hiding this comment.
Tests all passed on my machine using MYPYPATH, I'm now trying @hauntsaninja's way as well.
There was a problem hiding this comment.
Tests also all pass on my machine with the manual edit of mypy/typeshed/stubs/mypy-extensions/mypy_extensions.pyi.
I'm also happy for this to be reverted if mypy's CI starts breaking unexpectedly!
There was a problem hiding this comment.
Thanks for double-checking!
This comment has been minimized.
This comment has been minimized.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
#7928