Skip to content

Conversation

@AlexWaygood
Copy link
Member

This wasn't possible prior to #8280, which disabled pyright's reportSelfClsParameterName check

@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@@ -1,5 +1,5 @@
from typing_extensions import assert_type
from typing import Tuple
from typing_extensions import assert_type
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird, I wonder how this passed on my PR.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It surprised me too :)

@AlexWaygood AlexWaygood merged commit a1af16b into master Jul 12, 2022
@AlexWaygood AlexWaygood deleted the fractions branch July 12, 2022 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants