Add new Resampling enum to Pillow Image#8429
Closed
dynobo wants to merge 1 commit intopython:masterfrom
dynobo:master
Closed
Add new Resampling enum to Pillow Image#8429dynobo wants to merge 1 commit intopython:masterfrom dynobo:master
dynobo wants to merge 1 commit intopython:masterfrom
dynobo:master
Conversation
Author
|
Oh, never mind. #8419 was faster and is more complete... |
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: vision (https://github.com/pytorch/vision)
- torchvision/transforms/_pil_constants.py:7: error: Module has no attribute "Resampling" [attr-defined]
- torchvision/transforms/_pil_constants.py:8: error: Module has no attribute "Resampling" [attr-defined]
- torchvision/transforms/_pil_constants.py:9: error: Module has no attribute "Resampling" [attr-defined]
- torchvision/transforms/_pil_constants.py:10: error: Module has no attribute "Resampling" [attr-defined]
+ torchvision/transforms/_pil_constants.py:17: error: Incompatible types in assignment (expression has type "Literal[3]", variable has type "Resampling") [assignment]
+ torchvision/transforms/_pil_constants.py:18: error: Incompatible types in assignment (expression has type "Literal[2]", variable has type "Resampling") [assignment]
+ torchvision/transforms/_pil_constants.py:19: error: Incompatible types in assignment (expression has type "Literal[0]", variable has type "Resampling") [assignment]
+ torchvision/transforms/_pil_constants.py:20: error: Incompatible types in assignment (expression has type "Literal[2]", variable has type "Resampling") [assignment]
|
Collaborator
|
Just a little too slow, but thank you for contributing! :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should solve #8366.
(My first little PR here 🙈 )