Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Aug 5, 2022

@hauntsaninja hauntsaninja reopened this Aug 5, 2022
@github-actions

This comment has been minimized.

@AlexWaygood
Copy link
Member

Looks like our stripe stubs need a fair few updates -- @kkirsche, is this something you might be interested in helping out with? :)

@kkirsche
Copy link
Contributor

kkirsche commented Aug 5, 2022

I'll need to take a look at the library to see if it's one that I'd be a good fit for updating. I can certainly handle parts of it, but want to make sure I'm not biting off more than I can chew.

I found the v4 migration guide which may be of use from https://github.com/stripe/stripe-python/releases:
https://github.com/stripe/stripe-python/wiki/Migration-guide-for-v4

It seems they were still iterating rather quickly with 4.0.0 just coming out to clean up release bugs, so it may be a good fit to tackle next week as it stabilizes

@AlexWaygood
Copy link
Member

AlexWaygood commented Aug 5, 2022

If it's not for you, that's fine :)

You can see a comparison of the 3.5 and 4.2 releases here: stripe/stripe-python@v3.5.0...v4.0.2

@AlexWaygood AlexWaygood added the help wanted An actionable problem of low to medium complexity where a PR would be very welcome label Aug 20, 2022
@AlexWaygood AlexWaygood marked this pull request as draft September 2, 2022 14:49
@github-actions github-actions bot changed the title [stubsabot] Bump stripe to 4.0.* [stubsabot] Bump stripe to 4.2.* Oct 5, 2022
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions github-actions bot changed the title [stubsabot] Bump stripe to 4.2.* [stubsabot] Bump stripe to 5.0.* Nov 17, 2022
@github-actions
Copy link
Contributor Author

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@github-actions github-actions bot changed the title [stubsabot] Bump stripe to 5.0.* [stubsabot] Bump stripe to 5.1.* Feb 3, 2023
@JelleZijlstra JelleZijlstra force-pushed the stubsabot/stripe branch 2 times, most recently from 5f4e494 to 8a8d682 Compare February 7, 2023 00:13
@github-actions github-actions bot changed the title [stubsabot] Bump stripe to 5.1.* [stubsabot] Bump stripe to 5.2.* Feb 17, 2023
@JelleZijlstra JelleZijlstra force-pushed the stubsabot/stripe branch 2 times, most recently from 7b53f91 to 6b77ba4 Compare February 21, 2023 00:12
@github-actions github-actions bot changed the title [stubsabot] Bump stripe to 5.2.* [stubsabot] Bump stripe to 5.3.* Mar 24, 2023
@github-actions github-actions bot changed the title [stubsabot] Bump stripe to 5.3.* [stubsabot] Bump stripe to 5.4.* Mar 31, 2023
@github-actions github-actions bot changed the title [stubsabot] Bump stripe to 5.4.* [stubsabot] Bump stripe to 5.5.* Jul 14, 2023
@JelleZijlstra JelleZijlstra force-pushed the stubsabot/stripe branch 2 times, most recently from 423817e to f4d7e21 Compare July 21, 2023 00:11
@AlexWaygood AlexWaygood added the bot: stubsabot 🤖 Third-party stub updates by stubsabot 🤖 label Aug 10, 2023
@github-actions github-actions bot changed the title [stubsabot] Bump stripe to 5.5.* [stubsabot] Bump stripe to 6.0.* Aug 17, 2023
@github-actions github-actions bot changed the title [stubsabot] Bump stripe to 6.0.* [stubsabot] Bump stripe to 6.1.* Aug 25, 2023
@github-actions github-actions bot changed the title [stubsabot] Bump stripe to 6.1.* [stubsabot] Bump stripe to 6.2.* Sep 1, 2023
@github-actions github-actions bot changed the title [stubsabot] Bump stripe to 6.2.* [stubsabot] Bump stripe to 6.3.* Sep 7, 2023
@github-actions github-actions bot changed the title [stubsabot] Bump stripe to 6.3.* [stubsabot] Bump stripe to 6.4.* Sep 8, 2023
@github-actions github-actions bot changed the title [stubsabot] Bump stripe to 6.4.* [stubsabot] Bump stripe to 6.5.* Sep 16, 2023
@github-actions github-actions bot changed the title [stubsabot] Bump stripe to 6.5.* [stubsabot] Bump stripe to 6.6.* Sep 22, 2023
@github-actions github-actions bot changed the title [stubsabot] Bump stripe to 6.6.* [stubsabot] Bump stripe to 6.7.* Oct 6, 2023
@Avasam
Copy link
Collaborator

Avasam commented Oct 14, 2023

FWIW, stripe-python have been adding annotations and completing types recently https://github.com/stripe/stripe-python/pulls?q=is%3Apr+sort%3Aupdated-desc+is%3Aclosed+type
And seem to plan to ship py.typed soon https://github.com/stripe/stripe-python/pull/1074/files#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7

Related feature request: stripe/stripe-python#650

Typeshed is so far behind, it might just not be worth the update.

@github-actions github-actions bot changed the title [stubsabot] Bump stripe to 6.7.* [stubsabot] Bump stripe to 7.0.* Oct 17, 2023
@github-actions github-actions bot changed the title [stubsabot] Bump stripe to 7.0.* [stubsabot] Mark stripe as obsolete since 7.1.0 Oct 28, 2023
@srittau srittau marked this pull request as ready for review November 2, 2023 14:46
@srittau srittau merged commit b3fa05a into main Nov 2, 2023
@srittau srittau deleted the stubsabot/stripe branch November 2, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot: stubsabot 🤖 Third-party stub updates by stubsabot 🤖 help wanted An actionable problem of low to medium complexity where a PR would be very welcome

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants