Added _ExtendAction to argparse #8701
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_ExtendAction was added to argparse since python 3.8. I am adding it here, since it is missing Reference of the addition to the standard library: python/cpython@aa32a7e
This comment has been minimized.
This comment has been minimized.
AlexWaygood
requested changes
Sep 7, 2022
Member
AlexWaygood
left a comment
AlexWaygood
left a comment
There was a problem hiding this comment.
Looks good! We need to use a sys.version_info guard, though, since it's not available on 3.7:
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Contributor
Author
|
Thanks for the quick review! |
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: pylint (https://github.com/pycqa/pylint)
+ pylint/config/argument.py:370: error: Incompatible types in assignment (expression has type "Type[pylint.config.callback_actions._ExtendAction]", variable has type "Type[argparse._ExtendAction]") [assignment]
+ pylint/config/argument.py:368: error: Unused "type: ignore" comment
|
AlexWaygood
approved these changes
Sep 7, 2022
Member
AlexWaygood
left a comment
AlexWaygood
left a comment
There was a problem hiding this comment.
Thanks! And welcome to typeshed!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_ExtendAction was added to argparse since python 3.8. I am adding it here, since it is missing
Reference of the addition to the standard library: python/cpython@aa32a7e