Skip to content

typing.pyi: Improve comments for IO/TextIO #8913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
srittau merged 1 commit into from
Oct 17, 2022
Merged

typing.pyi: Improve comments for IO/TextIO #8913

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions stdlib/typing.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -638,7 +638,9 @@ TYPE_CHECKING: bool
# This differs from runtime, but better reflects the fact that in reality
# classes deriving from IO use different names for the arguments.
class IO(Iterator[AnyStr], Generic[AnyStr]):
# TODO use abstract properties
# At runtime these are all abstract properties,
# but making them abstract in the stub is hugely disruptive, for not much gain.
# See #8726
@property
def mode(self) -> str: ...
@property
Expand Down Expand Up @@ -691,7 +693,7 @@ class BinaryIO(IO[bytes]):
def __enter__(self) -> BinaryIO: ...

class TextIO(IO[str]):
# TODO use abstractproperty
# See comment regarding the @properties in the `IO` class
@property
def buffer(self) -> BinaryIO: ...
@property
Expand Down