Add stubs for flask-migrate #8967
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
So stubstest fails since the cli functions are not functions but click.Command or click.Group. click has inline types so we cannot use it here as a dependency right now. Any clue how to solve this? |
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
Anybody any idea? |
Member
|
Should we even include the cli functions in the stub? I imagine they're not supposed to be called directly. |
Member
I agree; we can probably just omit that file for now. Add an allowlist entry if stubtest complains. |
As discussed in miguelgrinberg/Flask-Migrate#492 types should be added to typeshed.
kasium
force-pushed
the
flask-migrate
branch
from
25afccf to
37e771a
Compare
kasium
force-pushed
the
flask-migrate
branch
from
ff90054 to
030359c
Compare
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
@JelleZijlstra @AlexWaygood thanks for the support |
AlexWaygood
reviewed
Nov 22, 2022
Member
AlexWaygood
left a comment
AlexWaygood
left a comment
There was a problem hiding this comment.
Mostly looks good -- a few comments below
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood
reviewed
Nov 22, 2022
AlexWaygood
approved these changes
Nov 22, 2022
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
hauntsaninja
pushed a commit
to python/mypy
that referenced
this pull request
Dec 20, 2022
Removals from `stubinfo.py`: - `atomicwrites` is archived and deprecated at runtime; stubs were removed from typeshed in python/typeshed#8925 - `attrs` has had inline types for a very long time now - `chardet` recently cut a release with inline types; typeshed's stubs were marked obsolete in python/typeshed#9318 - `cryptography` has had inline types for a very long time now; the only reason why it's still in typeshed is because other typeshed packages need `types-cryptography` as a dependency, and our testing infrastructure therefore can't currently cope with it being removed from typeshed. - `emoji` recently cut a release bundling stubs with the runtime package; typeshed's stubs were marked obsolete in python/typeshed#9051 - `termcolor` recently cut a release with inline types; typeshed's stubs were marked obsolete in python/typeshed#8746 - `prettytable` recently cut a release with inline types; typeshed's stubs were marked obsolete in python/typeshed#9023 Additions: - Stubs for `Xlib` were added in python/typeshed#9279 - Stubs for `consolemenu` were added in python/typeshed#8820 - Stubs for `dockerfile_parse` were added in python/typeshed#9305 - Stubs for `flask_migrate` were added in python/typeshed#8967 - Stubs for `paho.mqtt` were added in python/typeshed#8853 - Stubs for `pycocotools` were added in python/typeshed#9086 - Stubs for many `pywin32` modules were added in python/typeshed#8825, and multiple follow-up PRs - Stubs for `pyscreeze` were added in python/typeshed#8823
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in miguelgrinberg/Flask-Migrate#492 types should be added to typeshed.