Skip to content

Conversation

@sobolevn
Copy link
Member

Examples:

>>> import marshal
>>> marshal.loads(b'\xe9{\x00\x00\x00')
123
>>> marshal.loads(bytearray(b'\xe9{\x00\x00\x00'))
123
>>> marshal.loads(memoryview(b'\xe9{\x00\x00\x00'))
123

Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@github-actions

This comment has been minimized.

@@ -1,5 +1,5 @@
from _typeshed import ReadableBuffer
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
from _typeshed import ReadableBuffer
from _typeshed import ReadableBuffer, SupportsRead, SupportsWrite

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh you just did that, thanks! GitHub's UI doesn't handle this well: the "Commit" button still shows up on the suggestion but clicking it does nothing. :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already done ;)

@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@JelleZijlstra JelleZijlstra merged commit 8036bbd into python:master Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants