Update pywin32 to mypy 0.990 #9124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
| win32com.client.CLSIDToClass | ||
| win32com.client.connect | ||
| # Necessary for mypy to not throw AssertionError | ||
| # dynamic.CDipatch Necessary for mypy to not throw AssertionError |
Collaborator
Author
There was a problem hiding this comment.
I'm just being more explicit. N should be lowercase and I could wrap the class name in quotes.
I myself misunderstood my own comment as meaning this allowlist entry is somehow preventing mypy from failing (or maybe that mypy was failing if I stubbed the module). When it's actually: "I would exclude this stub if it wasn't for mypy failing due to this definition missing". So I figured it'd be good to be a bit more clear.
This comment has been minimized.
This comment has been minimized.
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turned off
ignore_missing_stub. Tested locally on Windows. Added missing types. Updatedstubtest_allowlist.txt