Skip to content

Fix broken stubsabot logic in find_first_release_with_py_typed #9760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexWaygood merged 3 commits into from
Feb 19, 2023
Merged

Fix broken stubsabot logic in find_first_release_with_py_typed #9760

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
95e633d
Fix broken stubsabot logic in `find_first_release_with_py_typed`
AlexWaygood Feb 19, 2023
3d268b1
Do Akuli's suggestion
AlexWaygood Feb 19, 2023
be94f62
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Feb 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions scripts/stubsabot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,15 +171,15 @@ async def release_contains_py_typed(release_to_download: PypiReleaseDownload, *,


async def find_first_release_with_py_typed(pypi_info: PypiInfo, *, session: aiohttp.ClientSession) -> PypiReleaseDownload | None:
release_iter = pypi_info.releases_in_descending_order()
release_iter = (release for release in pypi_info.releases_in_descending_order() if not release.version.is_prerelease)
latest_release = next(release_iter)
# If the latest release is not py.typed, assume none are.
if not (await release_contains_py_typed(release := next(release_iter), session=session)):
if not (await release_contains_py_typed(latest_release, session=session)):
return None

first_release_with_py_typed: PypiReleaseDownload | None = None
first_release_with_py_typed = latest_release
while await release_contains_py_typed(release := next(release_iter), session=session):
if not release.version.is_prerelease:
first_release_with_py_typed = release
first_release_with_py_typed = release
return first_release_with_py_typed


Expand Down