Endless loop in class EmitInterval

[tobiasbp]

Bug Report

If emit_interval is set to 0.0 in class EmitInterval, this loop will never end:

while self._carryover_time >= self._emit_interval:
            self._carryover_time -= self._emit_interval
            emit_count += 1

Recreate by using an emit controller like this:

ec = EmitInterval(0.0)

Potential fix:

# was self._emit_interval = emit_interval
self._emit_interval = max(emit_interval, 0.001)

[einarf]

Thanks. Maybe just raising an error is reasonable here?

[tobiasbp]

Thanks. Maybe just raising an error is reasonable here?

Yes, that's much better. Do you want me to make a PR?

[einarf]

Yes, that's much better. Do you want me to make a PR?

That would be awesome 👍

[Miho42]

I talked to @tobiasbp. I'd like to give it a try :)
I'll create a PR.