Skip to content

Refactor color handling into a new Color type #1639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
einarf merged 99 commits into from
Mar 29, 2023
Merged

Refactor color handling into a new Color type #1639

einarf merged 99 commits into from
Mar 29, 2023

Conversation

@pushfoo
Copy link
Member

@pushfoo pushfoo commented Mar 15, 2023 •
edited
Loading

  • Add backwards-compatible Color tuple subclass
  • Convert arcade.color and arcade.csscolor modules to use the new type
  • Port float normalization behavior to a property & deleted redundant get_three_three_float_color function
  • Port creation from uint24 values to a class method
  • Port creation from uint32 values to a class method
  • Port creation from normalized floats to a class method
  • Port creation from hex strings to a class method
  • Consolidate typing around the code base
  • Replace get_four_byte_color with Color.from_iterable
    • arcade.draw_commands
    • arcade.perf_graph
    • arcade.shape_list
    • arcade.text
    • arcade.examples
    • arcade.gui.widgets
    • arcade.sprite
    • doc/tutorials
    • tests/
  • Fix any lingering linting issues

Ibrahim2750mi
Ibrahim2750mi reviewed Mar 18, 2023
View reviewed changes
@pushfoo pushfoo force-pushed the color_refactor branch 3 times, most recently from 16daf0b to acd43b8 Compare March 19, 2023 08:09
@pushfoo pushfoo mentioned this pull request Mar 19, 2023
Merged
@pushfoo pushfoo force-pushed the color_refactor branch 6 times, most recently from f2623cb to 8d7a49b Compare March 20, 2023 10:03
@pushfoo pushfoo marked this pull request as ready for review March 20, 2023 13:32
pushfoo added 18 commits March 21, 2023 02:40
@pushfoo
Initial Color tuple subclass which doesn't break tests
17ac553
@pushfoo
Add basic from_ class methods to Color type
64f7973
@pushfoo
Move color module tests into new tests/color folder
3bc4bd0
@pushfoo
Fix Color.__new__: it's not __init__, must return a value
39a2393
@pushfoo
Add tests for Color.from_uint24
d4b3e65
@pushfoo
Remove uint24_to_three_byte_color
9ef80ca
@pushfoo
Add Color.__repr__ to make test failures easier to read
a075ce3
@pushfoo
Remove unneeded RGB import from drawing support
a9a899f
@pushfoo
Convert arcade.color to new Color type
8c23a19
@pushfoo
Convert arcade.csscolor to new Color type
cd4dfc4
@pushfoo
Fix docstring for Color.normalized
12e318c
@pushfoo
Add tests for Color.normalized
6f883b2
@pushfoo
Remove leftover uint24 import in arcade.__all__
23abefa
@pushfoo
Make tests pass by accounting for extra imports
82abee2
@pushfoo
Remove get_four_float_color from SpriteList
af1b772
@pushfoo
Remove get_four_float_color & tests
2543231
@pushfoo
Remove make_transparent_color
cd2462b
@pushfoo
Replace range error message func with Exception hierarchy
c72c1c3
pushfoo added 14 commits March 21, 2023 02:40
@pushfoo
Update typing for widget bases
fe3bba4
@pushfoo
Update Color annotations in buttons
e982c16
@pushfoo
Use Color.from_iterable in BasicSprite.color setter
2d9da5c
@pushfoo
Use Color.from_iterable in SpriteList.color setter
c92d82e
@pushfoo
Remove get_four_byte_color usage in examples
772e396
@pushfoo
Remove get_four_byte_color from arcade.gui.widgets.text
4b91491
@pushfoo
Remove get_four_byte_color from examples
48f9e32
@pushfoo
Remove get_four_byte_color tests
451b06d
@pushfoo
Rename test_drawing_support.py to test_rotate_point.py
cee1890
@pushfoo
Remove get_four_byte_color entirely
f9b05da
@pushfoo
Clean up unused imports
3cab64e
@pushfoo
Add docstrings for custom exceptions including einarf's advice on nor…
fd4e273 
…malized floats
@pushfoo
Specify rgb positionally in Color.from_normalized
5ac0144
@pushfoo
Make Color.from_normalized consistent with the other converter classm…
9ce5390 
…ethods
@pushfoo pushfoo mentioned this pull request Mar 21, 2023
Closed
4 tasks
einarf
einarf reviewed Mar 29, 2023
View reviewed changes
einarf
einarf reviewed Mar 29, 2023
View reviewed changes
@einarf einarf merged commit 15f6977 into pythonarcade:development Mar 29, 2023
@pushfoo pushfoo mentioned this pull request May 22, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@einarf einarf einarf left review comments

+1 more reviewer

@Ibrahim2750mi Ibrahim2750mi Ibrahim2750mi left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pushfoo @einarf @Ibrahim2750mi