Skip to content

Conversation

@gran4
Copy link
Contributor

@gran4 gran4 commented Aug 7, 2023

It seems like there is a problem unrelated to my code that is breaking the tests.
Do not merge, there is an on going conversation on whether this was removed because it broke something.

@gran4 gran4 marked this pull request as draft August 8, 2023 03:49
@gran4 gran4 changed the title Fix https://github.com/pythonarcade/arcade/issues/1839 Fix https://github.com/pythonarcade/arcade/issues/1839[WIP] Aug 8, 2023
@einarf
Copy link
Member

einarf commented Feb 18, 2024

Related to this? #1839

@eruvanos
Copy link
Member

eruvanos commented Feb 19, 2024

Hi,

there is an issue with the UI.

UILabel often gets its real width during the layout phase, which means it has no initial width given. Still setting align=center will effect the text position after the layout phase and center the text.

Also from my point of view it makes no sense, to enforce multiline based on the alignment. Also it overwrites the given value, which feels unintuitive from my point of view.

@eruvanos eruvanos self-requested a review February 19, 2024 19:14
@eruvanos
Copy link
Member

Update: I will remove the multiline overwrites when align set !=left in all arcade.text areas.
While align might not have an effect without multiline, the given multiline value should not be overwritten by some magic.

@eruvanos eruvanos closed this Feb 27, 2024
@eruvanos eruvanos mentioned this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants