Improved behavior of "visible" setter and getter properties in BasicSprite. #2029
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is so the alpha state is stored when setting visibility. originally it overrode the alpha which was stinky.
DragonMoffon
changed the title
pushfoo
requested changes
Mar 19, 2024
Member
There was a problem hiding this comment.
TL;DR: There are nasty, subtle details which need changes to take care of.
The general changes are good, however. I also think we might have uncovered room for improvement in Color.from_iterable since we leave an unpack underflow uncaught, and it results in a somewhat vague exception.
DragonMoffon
changed the title
DragonMoffon
changed the title
pushfoo
requested changes
Mar 21, 2024
Member
pushfoo
left a comment
pushfoo
left a comment
There was a problem hiding this comment.
We should fix this while we're here.
* Correct and expand docstring for BasicSprite.visible * Add comment explaining that SpriteList handles the alpha/visible interaction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is so the alpha state is stored when setting visibility. Originally, it overrode the alpha, which was stinky.