Fix Camera2D render target size bug & improve durability #2050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use final render_target.size instead of window size * Clean up . accesses for shorter code + tiny speed boost
* Get render_target earlier * Use render_target.size to define width and height * Make code cleaner +_ a tiny bit faster with less . access
* Make it a class method with a typing_extensions.Self return type * Add a test for subclassing safety
Member
Author
|
The remaining type issues in the GitHub based tests all appear to be GUI stuff. |
Member
Author
|
TL;DR: Changes didn't break anything, it's just the GUI pyright issues again The changes are responses to Discord feedback from DragonMoffon. GitHub based tests still report the same GUI breakage as before, and those are unrelated to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Camera2DCamera2D.from_raw_datainheritance-safeCamera2D.viewport's docstringFollow-up Work
Vec types
Once #2043 is merged, we should probably use its
Vec*types liberallyFancy / Named Tuple types?
Would
NamedTupleor similar be better for internalviewportrepresentation? Benefits I can see:LRBT and similar types might be useful.
Validation?
Currently we don't do any pyglet-style implicit unpacks or length checks. Maybe we should?