Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the struct handling code by moving it into a dedicated structs module and improving the code organization. The refactor introduces a new StructType class to encapsulate struct-related functionality and replaces the previous dictionary-based approach with object-oriented design.
- Moved struct processing code from
structs_pass.pytostructs/structs_pass.py - Created new
StructTypeclass to replace dictionary-based struct representation - Updated all references throughout the codebase to use the new
StructTypeinterface
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pythonbpf/structs_pass.py | Deleted - moved to structs/ subdirectory |
| pythonbpf/structs/structs_pass.py | New modular struct processing with improved error handling and logging |
| pythonbpf/structs/struct_type.py | New StructType class encapsulating struct operations |
| pythonbpf/functions_pass.py | Updated to use new StructType interface |
| pythonbpf/expr_pass.py | Updated to use new StructType interface |
| pythonbpf/codegen.py | Updated import path for struct processing |
| pythonbpf/bpf_helper_handler.py | Updated to use new StructType interface |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
1899a6c to
b784ce2
Compare
b784ce2 to
3ded17b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.