Skip to content

Tom Slater's peer review: output analysis #177

@amyheather

Description

@amyheather

Peer review from @tbslater

Initialisation Bias

  • Typo…
Image
  • This needs rewriting…
Image
  • Might be worth explaining what these functions are doing…
Image
  • I think the following function would benefit from some line by line commenting as it is not always clear how each function is manipulating the data. --> Function has quite alot of comments and then broken down line by line with markdown explanations, so will not add any further for this.
Image

Just scrolled down and the explanation of warm-up function helps. But I’d still add some more commenting 😊

Performance measures

I like the comparisons drawn between DES and queueing theory (without going into any unnecessary detail).
The utilisation function is very well explained.

  • Note: the average would be the total area / time elapsed. But I like the visual demonstration – it helps cement the idea.
Image
  • A summary of all the performance metrics at the end might be useful.

Replications

  • Going back to randomness and the associated plot, I think this plot and explanation better represents the impact of randomness. Something similar earlier might be beneficial
Image
  • Maybe include some performance metrics in the code output (e.g. utilisation).

Length of Warm-Up

Nice plot showing steady-state behaviour.

  • How much do the results change if you move the warm-up cutoff forwards or backwards? Could you show these results?

Number of Replications

  • Manual inspection – I think this needs a little more explaining (i.e. what all the output is showing).

  • Automated – so do you just select the highest number of runs (i.e. 19 in this case)? I’d like a sentence which uses the output to state the amount of replications you would use for this model.

Parallel Processing

Nice and clear 😊

Metadata

Metadata

Assignees

Labels

peer reviewFeedback from peer review of the repo

Type

No type

Projects

Status

In progress

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions