IR Spectra longer exercise#58
Merged
arm61 merged 3 commits intopythoninchemistry:masterfrom May 4, 2020
Merged
Conversation
Contributor
Author
|
pinging #34 |
j-m-dean
reviewed
May 1, 2020
Contributor
There was a problem hiding this comment.
Some comments:
- Previous notebooks had prerequisites before importation of modules
- “Benyl alcohol. YOu” —> benzyl alcohol. You (aims section)
- “tolene.csv” —> toluene.csv (aims section)
- “Large feature in the toulene isolated data” —> toluene (above the fitting section)
- “In order to determine this line of best fit, we use a process called, we have a metric that we want to minimise which represents the difference between the data and the model (the straight line).” - I think you’ve re-written this and not deleted some of the previous text (fitting section)
- “straight line model through, linear regression, a mathematical ” —> “straight line model through linear regression, a mathematical”
- Axis titles on plots
- “to notice that the vales for wavenumber” —> values (interpolation section)
- “spectra are not the sam” —>same (interpolation section)
- “Additionaly, since our model”—> additionally (interp)
- “be created form mixing the toulene”—>from, toluene (interpolation)
- “within the exisiting range”—> existing(interp)
- A clearer explanation of terms may be required for the terms y_model,i etc. Maybe give an example. This was often something students struggled understanding in CH40208.
Are model solutions provided for the longer exercises?
Contributor
Author
Contributor
|
@arm61 the explanation is much clearer. I think students will have an easier time understanding it now. There is a typo in the final bullet point though: "so is the gradient is 1 and intercept is 0" --> so if the... |
Contributor
Author
|
Fixed, I will merge once it passes. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thoughts? I dropped the MCMC stuff compared to the ch40208 cause I wanted to focus on the "working with data" part.