Added link validator. #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amolkahat
force-pushed
the
url_validator
branch
2 times, most recently
from
25ec6d8 to
e28a60f
Compare
Contributor
|
Please add some test data in tests folder so that it can be validated |
raukadah
reviewed
Dec 7, 2019
Member
|
@amolkahat thanks for PR... please have look on |
amolkahat
force-pushed
the
url_validator
branch
3 times, most recently
from
78b5df7 to
97f5609
Compare
- It will check link is valid or not. - If link is like `https://<hostname>:<port>` then it should mark it as skip. Signed-off-by: Amol Kahat <amolkahat@gmail.com>
amolkahat
force-pushed
the
url_validator
branch
from
97f5609 to
3f7a345
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://<hostname>:<port>then it should markit as skip.
Signed-off-by: Amol Kahat amolkahat@gmail.com
Fixes #12