Skip to content

intx weight only linear quantizer for mps#1192

Merged
facebook-github-bot merged 1 commit intopytorch:mainfrom
manuelcandales:export-D65079774
Nov 19, 2024
Merged

intx weight only linear quantizer for mps#1192
facebook-github-bot merged 1 commit intopytorch:mainfrom
manuelcandales:export-D65079774

Conversation

@manuelcandales
Copy link
Copy Markdown
Contributor

Differential Revision: D65079774

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Oct 29, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1192

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit 87826de with merge base 6234116 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 29, 2024
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D65079774

Comment thread torchao/experimental/ops/mps/register.mm
Comment thread torchao/experimental/ops/mps/register.mm
Comment thread torchao/experimental/quant_api.py Outdated
Comment thread torchao/experimental/quant_api.py Outdated
Comment thread torchao/experimental/ops/mps/register.mm
manuelcandales added a commit to manuelcandales/ao that referenced this pull request Oct 30, 2024
Summary: Pull Request resolved: pytorch#1192

Differential Revision: D65079774
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D65079774

Copy link
Copy Markdown
Contributor

@kimishpatel kimishpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments

Comment thread torchao/experimental/ops/mps/register.mm
Comment thread torchao/experimental/ops/mps/register.mm
Comment thread torchao/experimental/ops/mps/register.mm
Comment thread torchao/experimental/quant_api.py
Comment thread torchao/experimental/quant_api.py Outdated
Comment thread torchao/experimental/ops/mps/test/test_quantizer.py Outdated
Comment thread torchao/experimental/ops/mps/test/test_quantizer.py Outdated
Comment thread torchao/experimental/ops/mps/test/test_quantizer.py Outdated
Comment thread torchao/experimental/ops/mps/test/test_quantizer.py
Comment thread torchao/experimental/ops/mps/test/test_quantizer.py Outdated
manuelcandales added a commit to manuelcandales/ao that referenced this pull request Oct 30, 2024
Summary: Pull Request resolved: pytorch#1192

Differential Revision: D65079774
manuelcandales added a commit to manuelcandales/ao that referenced this pull request Oct 30, 2024
Summary: Pull Request resolved: pytorch#1192

Differential Revision: D65079774
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D65079774

1 similar comment
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D65079774

Comment thread torchao/experimental/ops/mps/test/test_quantizer.py Outdated
manuelcandales added a commit to manuelcandales/ao that referenced this pull request Nov 13, 2024
Summary: Pull Request resolved: pytorch#1192

Differential Revision: D65079774
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D65079774

manuelcandales added a commit to manuelcandales/ao that referenced this pull request Nov 13, 2024
Summary: Pull Request resolved: pytorch#1192

Differential Revision: D65079774
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D65079774

manuelcandales added a commit to manuelcandales/ao that referenced this pull request Nov 13, 2024
Summary: Pull Request resolved: pytorch#1192

Differential Revision: D65079774
manuelcandales added a commit to manuelcandales/ao that referenced this pull request Nov 13, 2024
Summary: Pull Request resolved: pytorch#1192

Differential Revision: D65079774
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D65079774

1 similar comment
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D65079774

@manuelcandales manuelcandales added the module: not user facing Use this tag if you don't want this PR to show up in release notes label Nov 13, 2024
Copy link
Copy Markdown
Contributor

@kimishpatel kimishpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments

Comment thread torchao/experimental/ops/mps/test/test_quantizer.py Outdated
Comment thread torchao/experimental/quant_api.py Outdated
Comment thread torchao/experimental/quant_api.py
Comment thread torchao/experimental/quant_api.py
Comment thread torchao/experimental/quant_api.py Outdated
Comment thread torchao/experimental/ops/mps/test/test_quantizer.py
manuelcandales added a commit to manuelcandales/ao that referenced this pull request Nov 18, 2024
Summary: Pull Request resolved: pytorch#1192

Differential Revision: D65079774
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D65079774

Summary: Pull Request resolved: pytorch#1192

Differential Revision: D65079774
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D65079774

@facebook-github-bot facebook-github-bot merged commit 26648c2 into pytorch:main Nov 19, 2024
yanbing-j pushed a commit to yanbing-j/ao that referenced this pull request Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported module: not user facing Use this tag if you don't want this PR to show up in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants