Support dynamically quantized 2D convolutions#10347
Merged
mcr229 merged 26 commits intopytorch:mainfrom Apr 22, 2025
Merged
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10347
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit d82e080 with merge base ad7cd2b ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
Author
|
@pytorchbot label "topic: not user facing" |
mcr229
approved these changes
Apr 22, 2025
Contributor
mcr229
left a comment
There was a problem hiding this comment.
looks good! let's wait for CI to run and then we can merge. Thank you for the contribution!
Contributor
|
lintrunner failure isn't relevant and is fixed on main. Merging changes |
jackzhxng
added a commit
that referenced
this pull request
Apr 23, 2025
This reverts commit cfd1be3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add initial support for dynamically quantized Conv2d in XNNPACK:
convtoDYNAMIC_OPSfor annotationnum_nonbatch_dimsbased on whether the node feeds into a convnum_nonbatch_dimscheck from XNNCompilerFixes #9021
Test plan