Re-sync extension/pytree/function_ref.h with LLVM#10440
Merged
Conversation
Contributor
Author
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10440
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit 773b183 with merge base 1432243 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
This was referenced Apr 24, 2025
digantdesai
approved these changes
Apr 24, 2025
| EXPECT_EQ(item1.get(), 1); | ||
| val = 0; | ||
| FunctionRef<void(int32_t&)> ref2(one); | ||
| ref(val); |
Contributor
Author
|
bypassing two apparent tests flakes and merging. |
kedarnath03
pushed a commit
to kedarnath03/executorch
that referenced
this pull request
Jun 25, 2025
We had an old version, and that version didn't work quite right when handed a const ref to a callable. Just resync and note divergences from the original in the comment. Our old version also had an `explicit` constructor, which is *not* desirable because it complicates callsites. It was also a divergence from both LLVM and [the upcoming C++26 std::function_ref](https://en.cppreference.com/w/cpp/utility/functional/function_ref/function_ref). The test made invalid use of a FunctionRef -- you can't keep one around past the lifetime of the function object it refers to, but the test held onto a temporary capturing lambda in an object. I fixed the test. ghstack-source-id: 87eea49 ghstack-comment-id: 2828754943 Pull-Request-resolved: pytorch/executorch#10440
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had an old version, and that version didn't work quite right when
handed a const ref to a callable. Just resync and note divergences
from the original in the comment. Our old version also had an
explicitconstructor, which is not desirable because itcomplicates callsites. It was also a divergence from both LLVM and
the upcoming C++26
std::function_ref.
The test made invalid use of a FunctionRef -- you can't keep one
around past the lifetime of the function object it refers to, but the
test held onto a temporary capturing lambda in an object. I fixed the
test.