Skip to content

Unbreak pytree Buck build#10536

Merged
swolchok merged 1 commit intomainfrom
gh/swolchok/432/head
Apr 29, 2025
Merged

Unbreak pytree Buck build#10536
swolchok merged 1 commit intomainfrom
gh/swolchok/432/head

Conversation

@swolchok
Copy link
Contributor

@swolchok swolchok commented Apr 28, 2025

D73688265/#10441 broke it. Apparently nothing covered by OSS unittest-buck uses it.

@swolchok
Update
434e3e7 
[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

swolchok commented Apr 28, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

@swolchok swolchok requested a review from JacobSzwejbka as a code owner April 28, 2025 23:54
@pytorch-bot
Copy link

pytorch-bot bot commented Apr 28, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10536

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 75 Pending

As of commit 434e3e7 with merge base 6ca0800 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

swolchok added a commit that referenced this pull request Apr 28, 2025
@swolchok
Unbreak pytree Buck build
959346e 
D73688265/#10441 broke it. Apparently nothing covered by OSS unittest-buck uses it.


ghstack-source-id: 534ddec
ghstack-comment-id: 2837041003
Pull-Request-resolved: #10536
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 28, 2025
@swolchok
Copy link
Contributor Author

swolchok commented Apr 28, 2025

I tried OSS-buckifying the pytree build real quick, but it seems we have cpp_python_extension in extension/pytree/TARGETS and that's not supported right now.

@swolchok
Copy link
Contributor Author

swolchok commented Apr 28, 2025

(I spot-checked a broken build internally.)

@swolchok swolchok merged commit 22ba09e into main Apr 29, 2025
86 of 89 checks passed
@swolchok swolchok deleted the gh/swolchok/432/head branch April 29, 2025 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jack-Khuu Jack-Khuu Jack-Khuu approved these changes

@JacobSzwejbka JacobSzwejbka Awaiting requested review from JacobSzwejbka JacobSzwejbka is a code owner

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@swolchok @Jack-Khuu @facebook-github-bot