Skip to content

Qualcomm AI Engine Direct - fix for pytorch uplevel#10769

Merged
cccclai merged 3 commits intopytorch:mainfrom
CodeLinaro:dev_fix_for_pytorch_uplevel
May 20, 2025
Merged

Qualcomm AI Engine Direct - fix for pytorch uplevel#10769
cccclai merged 3 commits intopytorch:mainfrom
CodeLinaro:dev_fix_for_pytorch_uplevel

Conversation

@haowhsu-quic
Copy link
Collaborator

Summary

  • use 'fold_quantize=False' in convert_pt2e to prevent overwriting state_dict during lowering
  • change in _get_updated_graph_siganture to have signature detected correctly

@pytorch-bot
Copy link

pytorch-bot bot commented May 8, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10769

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Unrelated Failure

As of commit 186ee40 with merge base 7d9dd46 (image):

NEW FAILURE - The following job has failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 8, 2025
Summary
- use 'fold_quantize=False' in convert_pt2e to prevent overwriting
  state_dict during lowering
- change in _get_updated_graph_siganture to have signature detected
  correctly
@haowhsu-quic haowhsu-quic force-pushed the dev_fix_for_pytorch_uplevel branch from d292254 to 2e0535a Compare May 14, 2025 15:08
@haowhsu-quic
Copy link
Collaborator Author

@pytorchbot label "release notes: qualcomm"

@pytorch-bot pytorch-bot bot added the release notes: qualcomm Changes to the Qualcomm backend delegate label May 14, 2025
@haowhsu-quic haowhsu-quic marked this pull request as ready for review May 14, 2025 15:10
@facebook-github-bot
Copy link
Contributor

@cccclai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Copy link
Contributor

@cccclai cccclai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the prompt fix!

@facebook-github-bot
Copy link
Contributor

@cccclai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cccclai
Copy link
Contributor

cccclai commented May 16, 2025

Can you rebase? The lint error should be gone in main

@facebook-github-bot
Copy link
Contributor

@cccclai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cccclai cccclai merged commit d1c2683 into pytorch:main May 20, 2025
94 of 96 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: qualcomm Changes to the Qualcomm backend delegate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants