Arm backend: Suppress colors in pre-push if non-interactive#10783
Merged
zingo merged 1 commit intopytorch:mainfrom May 9, 2025
Merged
Arm backend: Suppress colors in pre-push if non-interactive#10783zingo merged 1 commit intopytorch:mainfrom
zingo merged 1 commit intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10783
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 36b9160 with merge base b1b46ee ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
perheld
added
partner: arm
Dont try to print with colors in the pre-push script if the script is non-interactive. This is to avoid getting broken output in the CI which doesnt support colors. Signed-off-by: per.held@arm.com Change-Id: I58b6a45de8b8403fa39ecbe299d380f3ca9fba62
perheld
force-pushed
the
upstream/ph-git-pre-push-non-interactive
branch
from
6b6eceb to
36b9160
Compare
zingo
approved these changes
May 9, 2025
Collaborator
|
Macos fail unrelated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dont try to print with colors in the pre-push script if the script is non-interactive. This is to avoid getting broken output in the CI which doesnt support colors.
Signed-off-by: per.held@arm.com
Change-Id: I58b6a45de8b8403fa39ecbe299d380f3ca9fba62
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218