Arm backend: test_conformer.py emergency fix#10950
Closed
zingo wants to merge 1 commit intopytorch:mainfrom
Closed
Arm backend: test_conformer.py emergency fix#10950zingo wants to merge 1 commit intopytorch:mainfrom
zingo wants to merge 1 commit intopytorch:mainfrom
Conversation
We enabled some new tests in this suite but they turend out to not work, lest back it out again and investigate. This make the unittest-arm-backend-with-no-fvp (test_pytest_models) test work again. Signed-off-by: Zingo Andersen <zingo.andersen@arm.com> Change-Id: I16580299bcd94cd5d7c2146a1759554d0026f4c6
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10950
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 3 New Failures, 1 Cancelled Job, 1 Unrelated FailureAs of commit 5adf760 with merge base d0848ca ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced May 16, 2025
Merged
Merged
Collaborator
Author
|
Hmm this is probably not the proper fix. Tests pass sometime som Im wondering if it's a rosource problem as we run the models on the same machine in parallell. Need to test some more. |
Collaborator
Author
|
This was not a problem, close without merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Some tests was changed from expected fail to pass in a recent PR but they turned out to not work.
Lets back them out again and investigate.
This make the unittest-arm-backend-with-no-fvp (test_pytest_models) test work again.
Test plan
By hand and in GitHub