Skip to content

Arm backend: Clean up matmul tests#10971

Merged
zingo merged 4 commits intopytorch:mainfrom
oscarandersson8218:matmul_unmark_flaky
May 20, 2025
Merged

Arm backend: Clean up matmul tests#10971
zingo merged 4 commits intopytorch:mainfrom
oscarandersson8218:matmul_unmark_flaky

Conversation

@oscarandersson8218
Copy link
Collaborator

@oscarandersson8218 oscarandersson8218 commented May 19, 2025 •
edited by pytorch-bot bot
Loading

  • Removes duplicated matmul tests.
  • Replaces pytest.mark_flaky with qtol for quantized tests cases of mm/bmm.

cc @digantdesai @freddan80 @per @zingo

@oscarandersson8218
Arm backend: Remove duplicted Matmul-tests
0393595 
torch.matmul was tested in both test_bmm and test_matmul.

Signed-off-by: Oscar Andersson <oscar.andersson@arm.com>
Change-Id: Ia84384071e6d27a7c8b171cfc79aba0b4b1e2422
@oscarandersson8218
Arm backend: Unmark test_bmm:tosa_bi as flaky
8eb6f7b 
Replace pytest.mark_flaky with qtol=1 for TOSA BI tests in test_bmm.py

Signed-off-by: Oscar Andersson <oscar.andersson@arm.com>
Change-Id: Idb71178cb458557a74d1518b8c8c3283ff7ff9ad
@pytorch-bot
Copy link

pytorch-bot bot commented May 19, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10971

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Cancelled Job

As of commit 412b5b0 with merge base b73f9d5 (image):

CANCELLED JOB - The following job was cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 19, 2025
@oscarandersson8218 oscarandersson8218 added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk release notes: none Do not include this in the release notes labels May 19, 2025
@zingo
Copy link
Collaborator

zingo commented May 19, 2025

Rebased after some Arm test fixes

@zingo zingo merged commit da62d5f into pytorch:main May 20, 2025
182 of 183 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zingo zingo zingo approved these changes

@digantdesai digantdesai Awaiting requested review from digantdesai digantdesai is a code owner

Assignees

No one assigned

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@oscarandersson8218 @zingo @facebook-github-bot