Conversation
Contributor
Author
|
Stack from ghstack (oldest at bottom): |
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11939
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 0196ccb with merge base 91c9ffa ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
swolchok
added a commit
that referenced
this pull request
Jun 24, 2025
We have vectorized (and parallelized) portable ops now as of #11912, so we don't need a handwritten optimized op that only does vectorization. (I spot-checked assembly to confirm the portable op is getting vectorized when we build optimized_portable_kernels.) ghstack-source-id: 7ac8d91 ghstack-comment-id: 3002062946 Pull-Request-resolved: #11939
facebook-github-bot
added
the
CLA Signed
Contributor
|
@swolchok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
manuelcandales
approved these changes
Jun 25, 2025
Contributor
manuelcandales
left a comment
manuelcandales
left a comment
There was a problem hiding this comment.
Wow, this is great!
hinriksnaer
pushed a commit
to hinriksnaer/executorch
that referenced
this pull request
Jun 26, 2025
We have vectorized (and parallelized) portable ops now as of pytorch#11912, so we don't need a handwritten optimized op that only does vectorization. (I spot-checked assembly to confirm the portable op is getting vectorized when we build optimized_portable_kernels.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have vectorized (and parallelized) portable ops now as of #11912, so we don't need a handwritten optimized op that only does vectorization. (I spot-checked assembly to confirm the portable op is getting vectorized when we build optimized_portable_kernels.)