Skip to content

Turn off CMAKE_MACOSX_BUNDLE for macOS Cmake preset#12594

Merged
shoumikhin merged 1 commit intomainfrom
shoumikhin-patch-1
Jul 17, 2025
Merged

Turn off CMAKE_MACOSX_BUNDLE for macOS Cmake preset#12594
shoumikhin merged 1 commit intomainfrom
shoumikhin-patch-1

Conversation

@shoumikhin
Copy link
Contributor

No description provided.

It's turned on by the toolchain and we likely don't want that
@shoumikhin shoumikhin requested a review from larryliu0820 as a code owner July 17, 2025 17:33
@shoumikhin shoumikhin requested a review from kirklandsign as a code owner July 17, 2025 17:33
@shoumikhin shoumikhin added the release notes: none Do not include this in the release notes label Jul 17, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Jul 17, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12594

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Unrelated Failure

As of commit 80667a1 with merge base 4456407 (image):

NEW FAILURE - The following job has failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 17, 2025
@larryliu0820
Copy link
Contributor

build-benchmark-app is failing

@shoumikhin shoumikhin merged commit 890a3ab into main Jul 17, 2025
200 of 202 checks passed
@shoumikhin shoumikhin deleted the shoumikhin-patch-1 branch July 17, 2025 19:23
@shoumikhin
Copy link
Contributor Author

@larryliu0820 should be gone after rebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants