Remove noautodeps from files inc executorch/sdk/bundled_program/schema/test/TARGETS#1302
Closed
r-barnes wants to merge 1 commit intopytorch:mainfrom
Closed
Remove noautodeps from files inc executorch/sdk/bundled_program/schema/test/TARGETS#1302r-barnes wants to merge 1 commit intopytorch:mainfrom
r-barnes wants to merge 1 commit intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/1302
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit a81a185 with merge base 554cd27 ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51492409 |
…a/test/TARGETS (pytorch#1302) Summary: autodeps automatically adds and removes dependencies from targets. Removing dependencies reduces build times, build sizes, and error surfaces. Adding dependencies gives your code the things it needs to work. This diff removes **noautodeps** from one or more TARGETS files, opting them into autodeps. This changes **should be low risk** because: * We have verified that `autodeps` runs correctly on the modified files * The TARGETS files in this diff contain _only additions_ and no removals of dependencies. Additions rarely break code. * We have verified that the additions do not create circular dependencies, which are the most common problem when dependencies are added. - If you approve of this diff, please use the "Accept & Ship" button :-) Reviewed By: meyering Differential Revision: D51492409
r-barnes
force-pushed
the
export-D51492409
branch
from
0aeeb3c to
a81a185
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51492409 |
Contributor
|
Closing stale PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
autodeps automatically adds and removes dependencies from targets. Removing dependencies reduces build times, build sizes, and error surfaces. Adding dependencies gives your code the things it needs to work.
This diff removes noautodeps from one or more TARGETS files, opting them into autodeps.
This changes should be low risk because:
autodepsruns correctly on the modified filesReviewed By: meyering
Differential Revision: D51492409