Improve optimum coverage in ET (more models, xnnpack on mac)#13400
Merged
Improve optimum coverage in ET (more models, xnnpack on mac)#13400
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13400
Note: Links to docs will display an error until the docs builds have been completed. ❌ 6 New Failures, 9 Pending, 1 Unrelated FailureAs of commit a0c373f with merge base 30a6f5e ( NEW FAILURES - The following jobs have failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
9f6c79e to
1ee83cb
Compare
c7f00d3 to
ce1e8ec
Compare
Contributor
|
LGTM |
metascroy
reviewed
Aug 14, 2025
| "gemma3-1b": ( | ||
| "unsloth/gemma-3-1b-it", | ||
| test_text_generation, | ||
| ), # does not export for CoreML |
Contributor
There was a problem hiding this comment.
IIRC, it does not export for portable/xnnpack either unless you swap the SDPA with the custom one.
So I think the export issue is general, not CoreML specific, but using custom SDPA "fixes" the export issue.
Contributor
Author
There was a problem hiding this comment.
Does CoreML use custom sdpa / custom kv cache update?
metascroy
approved these changes
Aug 14, 2025
c0f00c2 to
dab8404
Compare
dab8404 to
79b2841
Compare
kimishpatel
approved these changes
Aug 14, 2025
095dfb3 to
a0c373f
Compare
agrima1304
pushed a commit
to agrima1304/executorch
that referenced
this pull request
Aug 26, 2025
…#13400) ### Summary Improves CI coverage of Optimum in ET: - More model coverage - Add XNNPack coverage for mac - Adds perplexity checks for causal LM tests instead of just printing output - Refactors all Optimum CI to use the same testing modules. ### Test plan Run trunk tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improves CI coverage of Optimum in ET:
Test plan
Run trunk tests