Add 16A8W linear ops support and test by Ninja91 · Pull Request #13448 · pytorch/executorch

Ninja91 · 2025-08-15T03:15:42Z

Summary:

Adds linear ops test using the 16A8W config in INT16 profile.
Adds support in view ops validation for INT16 Dtype.
Validated with TOSA pipeline test.

Note: Not verified with tosa reference model run.

Differential Revision: D80308822

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

pytorch-bot · 2025-08-15T03:15:45Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13448

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Pending, 2 Unrelated Failures

As of commit acf553f with merge base 2100527 ():

NEW FAILURE - The following job has failed:

Build documentation / build (buck2) / Build doc (gh)
At least one of the pre-conditions you specified did not hold

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

pull / unittest / macos / macos-job (gh) (trunk failure)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 1
pull / unittest-editable / macos / macos-job (gh) (trunk failure)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 1

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot · 2025-08-15T03:15:51Z

This pull request was exported from Phabricator. Differential Revision: D80308822

github-actions · 2025-08-15T03:16:22Z

This PR needs a `release notes:` label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Summary: - Adds linear ops test using the 16A8W config in INT16 profile. - Adds support in view ops validation for INT16 Dtype. - Validated with TOSA pipeline test. Note: Not verified with tosa reference model run. Differential Revision: D80308822

facebook-github-bot · 2025-08-15T06:05:59Z

This pull request was exported from Phabricator. Differential Revision: D80308822

Summary: Pull Request resolved: pytorch#13448 - Adds linear ops test using the 16A8W config in INT16 profile. - Adds support in view ops validation for INT16 Dtype. - Validated with TOSA pipeline test. Note: Not verified with tosa reference model run. Differential Revision: D80308822

backends/arm/operators/op_view.py

backends/arm/quantizer/arm_quantizer.py

backends/arm/test/tester/test_pipeline.py

backends/arm/test/ops/test_linear.py

backends/arm/test/pytest.ini

backends/arm/test/ops/test_linear.py

Summary: - Adds linear ops test using the 16A8W config in INT16 profile. - Adds support in view ops validation for INT16 Dtype. - Validated with TOSA pipeline test. Note: Not verified with tosa reference model run. Differential Revision: D80308822

facebook-github-bot · 2025-08-15T20:25:54Z

This pull request was exported from Phabricator. Differential Revision: D80308822

Summary: Pull Request resolved: pytorch#13448 - Adds linear ops test using the 16A8W config in INT16 profile. - Adds support in view ops validation for INT16 Dtype. - Validated with TOSA pipeline test. Note: Not verified with tosa reference model run. Differential Revision: D80308822

Summary: - Adds linear ops test using the 16A8W config in INT16 profile. - Adds support in view ops validation for INT16 Dtype. - Validated with TOSA pipeline test. Note: Not verified with tosa reference model run. Differential Revision: D80308822

facebook-github-bot · 2025-08-15T21:35:06Z

This pull request was exported from Phabricator. Differential Revision: D80308822

facebook-github-bot · 2025-08-25T18:08:56Z

This pull request was exported from Phabricator. Differential Revision: D80308822

Summary: Pull Request resolved: pytorch#13448 - Adds linear ops test using the 16A8W config in INT16 profile. - Adds support in view ops validation for INT16 Dtype. - Validated with TOSA pipeline test. - Checked earlier marked flaky tests no longer flaky and remove markers. Note: Not verified with tosa reference model run. Reviewed By: digantdesai Differential Revision: D80308822

Ninja91 · 2025-08-25T18:14:06Z

GH issue: #13635

Summary: Pull Request resolved: pytorch#13448 - Adds linear ops test using the 16A8W config in INT16 profile. - Adds support in view ops validation for INT16 Dtype. - Validated with TOSA pipeline test. - Checked earlier marked flaky tests no longer flaky and remove markers. Note: Not verified with tosa reference model run. Reviewed By: digantdesai Differential Revision: D80308822

Summary: - Adds linear ops test using the 16A8W config in INT16 profile. - Adds support in view ops validation for INT16 Dtype. - Validated with TOSA pipeline test. - Checked earlier marked flaky tests no longer flaky and remove markers. Note: Not verified with tosa reference model run. Reviewed By: digantdesai Differential Revision: D80308822

facebook-github-bot · 2025-08-25T19:14:52Z

This pull request was exported from Phabricator. Differential Revision: D80308822

facebook-github-bot · 2025-08-25T19:18:40Z

This pull request was exported from Phabricator. Differential Revision: D80308822

Summary: Pull Request resolved: pytorch#13448 - Adds linear ops test using the 16A8W config in INT16 profile. - Adds support in view ops validation for INT16 Dtype. - Validated with TOSA pipeline test. - Checked earlier marked flaky tests no longer flaky and remove markers. Note: Not verified with tosa reference model run. Reviewed By: digantdesai Differential Revision: D80308822

Summary: - Adds linear ops test using the 16A8W config in INT16 profile. - Adds support in view ops validation for INT16 Dtype. - Validated with TOSA pipeline test. - Checked earlier marked flaky tests no longer flaky and remove markers. Note: Not verified with tosa reference model run. Reviewed By: digantdesai Differential Revision: D80308822

facebook-github-bot · 2025-08-25T19:51:25Z

This pull request was exported from Phabricator. Differential Revision: D80308822

facebook-github-bot · 2025-08-25T19:55:07Z

This pull request was exported from Phabricator. Differential Revision: D80308822

Summary: Pull Request resolved: pytorch#13448 - Adds linear ops test using the 16A8W config in INT16 profile. - Adds support in view ops validation for INT16 Dtype. - Validated with TOSA pipeline test. - Checked earlier marked flaky tests no longer flaky and remove markers. Note: Not verified with tosa reference model run. Reviewed By: digantdesai Differential Revision: D80308822

…#13641) Summary: This diff implements a 16A8W (16-bit activations, 8-bit weights) quantization configuration utility for the ExecutorTorch ARM backend, following the feedback from D79746479. ## Key Changes **1. New Quantization Configuration Function** - Add `get_16a8w_quantization_config()` in `fbcode/executorch/backends/arm/quantizer/arm_quantizer.py` - Provides 16-bit activations with HistogramObserver (better precision than 8A8W) - Maintains 8-bit weights with MinMaxObserver/PerChannelMinMaxObserver (memory efficient) - **Technically supported by TOSA through [EXT-INT16 extension/profile](https://www.mlplatform.org/tosa/tosa_spec.html#_conv2d)** ## Benefits - **Better Precision**: 16-bit activations provide higher precision than 8-bit. Useful for carrying precision for recurring neural nets. ghstack-source-id: 305459598 exported-using-ghexport Reviewed By: 3l1 Differential Revision: D79763381

Summary: - Adds linear ops test using the 16A8W config in INT16 profile. - Adds support in view ops validation for INT16 Dtype. - Validated with TOSA pipeline test. - Checked earlier marked flaky tests no longer flaky and remove markers. Note: Not verified with tosa reference model run. Reviewed By: digantdesai Differential Revision: D80308822

facebook-github-bot · 2025-08-25T20:04:26Z

This pull request was exported from Phabricator. Differential Revision: D80308822

Ninja91 · 2025-08-25T20:14:04Z

@pytorchmergebot

Ninja91 · 2025-08-25T20:24:25Z

@digantdesai @per strangely seeing https://github.com/pytorch/executorch/actions/runs/17219418500/job/48850992655 error which doesn't look related. Am i missing something here?

Ninja91 · 2025-08-25T21:44:33Z

Updated in a new PR: #13658. Closing this.

Ninja91 requested a review from digantdesai as a code owner August 15, 2025 03:15

meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 15, 2025

facebook-github-bot added the fb-exported label Aug 15, 2025

Ninja91 force-pushed the export-D80308822 branch from ca1cd7f to 793a055 Compare August 15, 2025 06:02

Ninja91 force-pushed the export-D80308822 branch from 793a055 to e8402a2 Compare August 15, 2025 06:06

digantdesai reviewed Aug 15, 2025

View reviewed changes

backends/arm/operators/op_view.py Outdated Show resolved Hide resolved

digantdesai reviewed Aug 15, 2025

View reviewed changes

backends/arm/quantizer/arm_quantizer.py Outdated Show resolved Hide resolved

digantdesai reviewed Aug 15, 2025

View reviewed changes

backends/arm/quantizer/arm_quantizer.py Outdated Show resolved Hide resolved

digantdesai reviewed Aug 15, 2025

View reviewed changes

backends/arm/test/tester/test_pipeline.py Show resolved Hide resolved

digantdesai reviewed Aug 15, 2025

View reviewed changes

backends/arm/test/tester/test_pipeline.py Outdated Show resolved Hide resolved

digantdesai reviewed Aug 15, 2025

View reviewed changes

backends/arm/test/ops/test_linear.py Show resolved Hide resolved

digantdesai reviewed Aug 15, 2025

View reviewed changes

backends/arm/test/pytest.ini Outdated Show resolved Hide resolved

digantdesai reviewed Aug 15, 2025

View reviewed changes

backends/arm/test/ops/test_linear.py Show resolved Hide resolved

digantdesai added the ciflow/trunk label Aug 15, 2025

digantdesai requested a review from per August 15, 2025 15:28

Ninja91 force-pushed the export-D80308822 branch from e8402a2 to e725aa7 Compare August 15, 2025 20:21

pytorch-bot bot removed the ciflow/trunk label Aug 15, 2025

Ninja91 force-pushed the export-D80308822 branch 2 times, most recently from bad2472 to cd39120 Compare August 15, 2025 21:28

Ninja91 force-pushed the export-D80308822 branch from 79d958b to 5a7189c Compare August 25, 2025 18:08

Ninja91 mentioned this pull request Aug 25, 2025

Add 16A8W linear ops support and test #13635

Closed

Ninja91 self-assigned this Aug 25, 2025

Ninja91 force-pushed the export-D80308822 branch from 5a7189c to 56e8f7c Compare August 25, 2025 19:07

Ninja91 force-pushed the export-D80308822 branch from 56e8f7c to cace06e Compare August 25, 2025 19:14

Ninja91 force-pushed the export-D80308822 branch from cace06e to f034a00 Compare August 25, 2025 19:14

Ninja91 force-pushed the export-D80308822 branch from f034a00 to aa0b3f7 Compare August 25, 2025 19:18

Ninja91 force-pushed the export-D80308822 branch from aa0b3f7 to 6af0907 Compare August 25, 2025 19:50

Ninja91 force-pushed the export-D80308822 branch from 6af0907 to 5fc2ffe Compare August 25, 2025 19:51

Ninja91 added 2 commits August 25, 2025 13:03

Ninja91 mentioned this pull request Aug 25, 2025

Add 16A8W linear ops support and test #13658

Merged

Conversation

Ninja91 commented Aug 15, 2025 • edited by pytorch-bot bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Aug 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13448

❌ 1 New Failure, 1 Pending, 2 Unrelated Failures

Uh oh!

facebook-github-bot commented Aug 15, 2025

Uh oh!

github-actions bot commented Aug 15, 2025

This PR needs a release notes: label

Uh oh!

facebook-github-bot commented Aug 15, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

facebook-github-bot commented Aug 15, 2025

Uh oh!

facebook-github-bot commented Aug 15, 2025

Uh oh!

facebook-github-bot commented Aug 25, 2025

Uh oh!

Ninja91 commented Aug 25, 2025

Uh oh!

facebook-github-bot commented Aug 25, 2025

Uh oh!

facebook-github-bot commented Aug 25, 2025

Uh oh!

facebook-github-bot commented Aug 25, 2025

Uh oh!

facebook-github-bot commented Aug 25, 2025

Uh oh!

facebook-github-bot commented Aug 25, 2025

Uh oh!

Ninja91 commented Aug 25, 2025

Uh oh!

Ninja91 commented Aug 25, 2025

Uh oh!

Ninja91 commented Aug 25, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Ninja91 commented Aug 15, 2025 •

edited by pytorch-bot bot

Loading

pytorch-bot bot commented Aug 15, 2025 •

edited

Loading

This PR needs a `release notes:` label