Skip to content

Retake: Merged Arm backend: Add INT16 support to rescale operation #13802#14300

Closed
lucylq wants to merge 1 commit intomainfrom
nitin-13802
Closed

Retake: Merged Arm backend: Add INT16 support to rescale operation #13802#14300
lucylq wants to merge 1 commit intomainfrom
nitin-13802

Conversation

@lucylq
Copy link
Contributor

@lucylq lucylq commented Sep 15, 2025

#13802 (comment) failed to cp to main

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 15, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14300

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 113 Pending

As of commit 2149436 with merge base 957915f (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 15, 2025
@github-actions
Copy link

github-actions bot commented Sep 15, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@Ninja91 @lucylq
Add 16A8W support and test for add operation
2149436 
Add 16A8W quantization support and test for the add operation in ExecutorTorch ARM backend.

This follows the pattern established for linear operations, extending int16 support to add operations.

Changes:
- Add INT16 dtype validation support in op_add.py
- Add test_add_tensor_16a8w_tosa_INT test function
- Enable test_add.py in test targets configuration

The 16A8W configuration uses 16-bit activations with 8-bit weights, enabling higher precision for activations while maintaining weight efficiency.

Differential Revision: [D80510463](https://our.internmc.facebook.com/intern/diff/D80510463/)

[ghstack-poisoned]
@lucylq lucylq closed this Sep 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@digantdesai digantdesai Awaiting requested review from digantdesai digantdesai will be requested when the pull request is marked ready for review digantdesai is a code owner

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lucylq @Ninja91