Make _get_program_from_buffer work for bundled programs#14435
Merged
zingo merged 2 commits intopytorch:mainfrom Sep 22, 2025
Merged
Make _get_program_from_buffer work for bundled programs#14435zingo merged 2 commits intopytorch:mainfrom
zingo merged 2 commits intopytorch:mainfrom
Conversation
Add some cmake to only do this if executorch is built with bundleio. codegen/tools subdirectory needs to be moved in top-level CmakeLists.txt to have access to the bundled_program target. Signed-off-by: Erik Lundell <erik.lundell@arm.com> Change-Id: Ic953bdfd5223eb835e46150bde19b08b082e8444
Signed-off-by: Erik Lundell <erik.lundell@arm.com> Change-Id: Ib7fbdb7190312320d73a937bc285db7140d2bb1a
Erik-Lundell
requested review from
digantdesai,
kirklandsign,
larryliu0820,
lucylq and
mergennachin
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14435
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 2 Unrelated FailuresAs of commit 93d51bb with merge base 246009b ( NEW FAILURE - The following job has failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following job failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
Erik-Lundell
added
partner: arm
kimishpatel
added a commit
that referenced
this pull request
Sep 22, 2025
…)" This reverts commit 5768cf8.
kimishpatel
added a commit
that referenced
this pull request
Sep 22, 2025
) Reverts #14435 `buf_len` and some other variables unused related stuff is breaking a bunch of internal builds
StrycekSimon
pushed a commit
to nxp-upstream/executorch
that referenced
this pull request
Sep 23, 2025
Add some cmake to only do this if executorch is built with bundleio. codegen/tools subdirectory include needs to be moved in top-level CmakeLists.txt to have access to the bundled_program target. Follow-up patch to enable the fix in arm backend. Signed-off-by: Erik Lundell <erik.lundell@arm.com>
StrycekSimon
pushed a commit
to nxp-upstream/executorch
that referenced
this pull request
Sep 23, 2025
…orch#14487) Reverts pytorch#14435 `buf_len` and some other variables unused related stuff is breaking a bunch of internal builds
zingo
pushed a commit
that referenced
this pull request
Sep 29, 2025
This is a re-upload of #14435, with variables moved inside #ifdef to not get unused variables when building without devtools. --------------------------------------- Add some cmake to only do this if executorch is built with bundleio. codegen/tools subdirectory include needs to be moved in top-level CmakeLists.txt to have access to the bundled_program target. Follow-up patch to enable the fix in arm backend. Signed-off-by: Erik Lundell <erik.lundell@arm.com>
jirioc
pushed a commit
to nxp-upstream/executorch
that referenced
this pull request
Dec 19, 2025
Add some cmake to only do this if executorch is built with bundleio. codegen/tools subdirectory include needs to be moved in top-level CmakeLists.txt to have access to the bundled_program target. Follow-up patch to enable the fix in arm backend. Signed-off-by: Erik Lundell <erik.lundell@arm.com>
jirioc
pushed a commit
to nxp-upstream/executorch
that referenced
this pull request
Dec 19, 2025
…orch#14487) Reverts pytorch#14435 `buf_len` and some other variables unused related stuff is breaking a bunch of internal builds
jirioc
pushed a commit
to nxp-upstream/executorch
that referenced
this pull request
Dec 19, 2025
…ch#14503) This is a re-upload of pytorch#14435, with variables moved inside #ifdef to not get unused variables when building without devtools. --------------------------------------- Add some cmake to only do this if executorch is built with bundleio. codegen/tools subdirectory include needs to be moved in top-level CmakeLists.txt to have access to the bundled_program target. Follow-up patch to enable the fix in arm backend. Signed-off-by: Erik Lundell <erik.lundell@arm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add some cmake to only do this if executorch is built with bundleio.
codegen/tools subdirectory include needs to be moved in top-level CmakeLists.txt
to have access to the bundled_program target.
Follow-up patch to enable the fix in arm backend.
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218