Shift Left: Try building and testing selective_build in OSS#14499

Merged

facebook-github-bot merged 1 commit intomainfrom

Sep 23, 2025

Contributor

mergennachin commented Sep 23, 2025 •

edited

Loading

Enable buck targets in OSS under codegen/tools/targets.bzl
Build all buck targets in OSS under codegen/tools/... (Can't test yet due to torch not available in OSS buck)
Run test_tools_selective_build.py in pytest
Building on top of Shift Left: Run selective build CI test with more restrictions #14488

pytorch-bot bot commented Sep 23, 2025 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14499

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 3 Cancelled Jobs, 1 Unrelated Failure

As of commit 42e9adc with merge base 95888a4 ():

NEW FAILURES - The following jobs have failed:

pull / unittest-editable / macos / macos-job (gh)
exir/tests/test_quant_fusion_pass.py::TestQuantFusionPass::test_embedding_torchao
trunk / test-arm-ootb-linux / linux-job (gh)
RuntimeError: Command docker exec -t a40c22c90b28bd08029717a8d7abe1f680b536c82520231593d1c0f909408037 /exec failed with exit code 1

CANCELLED JOBS - The following jobs were cancelled. Please retry:

Check Labels (gh)
pull / test-static-llama-qnn-linux / linux-job (gh)
##[error]The operation was canceled.
trunk / test-arm-backend (test_pytest_ops_ethosu_fvp) / linux-job (gh)
##[error]The operation was canceled.

FLAKY - The following job failed but was likely due to flakiness present on trunk:

trunk / unittest-release / windows / windows-job (gh) (matched win rule in flaky-rules.json)
##[error]The operation was canceled.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

meta-cla bot added the CLA Signed label

github-actions bot commented Sep 23, 2025

This PR needs a `release notes:` label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Contributor

facebook-github-bot commented Sep 23, 2025

@mergennachin has imported this pull request. If you are a Meta employee, you can view this in D83024265.

mergennachin force-pushed the run_buck_test branch from 5d1aac9 to ea6ff60 Compare

September 23, 2025 13:07

mergennachin changed the title ~~Try testing in OSS~~ Try testing selective_build in OSS

mergennachin force-pushed the run_buck_test branch 2 times, most recently from fffa9ef to 9ee0494 Compare

September 23, 2025 14:39

Contributor

facebook-github-bot commented Sep 23, 2025

@mergennachin has imported this pull request. If you are a Meta employee, you can view this in D83024265.

mergennachin force-pushed the run_buck_test branch 2 times, most recently from 1999690 to 39cce76 Compare

September 23, 2025 15:32

Contributor

facebook-github-bot commented Sep 23, 2025

@mergennachin has imported this pull request. If you are a Meta employee, you can view this in D83024265.

mergennachin force-pushed the run_buck_test branch from 39cce76 to 71787e1 Compare

September 23, 2025 15:42

Contributor

facebook-github-bot commented Sep 23, 2025

@mergennachin has imported this pull request. If you are a Meta employee, you can view this in D83024265.

mergennachin marked this pull request as ready for review

September 23, 2025 15:59

mergennachin requested review from JacobSzwejbka, larryliu0820, lucylq and swolchok as code owners

September 23, 2025 15:59

mergennachin changed the title ~~Try testing selective_build in OSS~~ Try building and testing selective_build in OSS

mergennachin requested a review from GregoryComer

September 23, 2025 15:59

mergennachin changed the title ~~Try building and testing selective_build in OSS~~ Shift Left: Try building and testing selective_build in OSS

GregoryComer approved these changes

View reviewed changes

mergennachin force-pushed the run_buck_test branch from 71787e1 to 42e9adc Compare

September 23, 2025 17:51

Contributor

facebook-github-bot commented Sep 23, 2025

@mergennachin has imported this pull request. If you are a Meta employee, you can view this in D83024265.

lucylq approved these changes

View reviewed changes

Contributor

lucylq left a comment

Thanks for these changes 🙏


          Shift Left: Try building and testing selective_build in OSS (#14499)

9c5cede

Summary:
- Enable buck targets in OSS under codegen/tools/targets.bzl
- Build all buck targets in OSS under codegen/tools/... (Can't test yet due to torch not available in OSS buck)
- Run test_tools_selective_build.py in pytest
- Building on top of #14488

Pull Request resolved: #14499

Reviewed By: lucylq

Differential Revision: D83024265

Pulled By: mergennachin

Contributor

facebook-github-bot commented Sep 23, 2025

@mergennachin has exported this pull request. If you are a Meta employee, you can view the originating diff in D83024265.

facebook-github-bot added fb-exported meta-exported labels

mergennachin force-pushed the run_buck_test branch from 42e9adc to 9c5cede Compare

September 23, 2025 19:14

Contributor Author

mergennachin commented Sep 23, 2025

cc @Erik-Lundell, @zingo Another PR to help test selective_build build jobs

mergennachin mentioned this pull request

Make _get_program_from_buffer work for bundled programs take 2 #14503

Merged

facebook-github-bot merged commit 3d1f591 into main

265 of 270 checks passed

facebook-github-bot deleted the run_buck_test branch

September 23, 2025 23:41

jirioc pushed a commit to nxp-upstream/executorch that referenced this pull request


          Shift Left: Try building and testing selective_build in OSS

4a08f0d

Differential Revision: D83024265

Pull Request resolved: pytorch#14499

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

GregoryComer GregoryComer approved these changes

lucylq lucylq approved these changes

larryliu0820 Awaiting requested review from larryliu0820 larryliu0820 is a code owner

JacobSzwejbka Awaiting requested review from JacobSzwejbka JacobSzwejbka is a code owner

swolchok Awaiting requested review from swolchok

Labels

CLA Signed fb-exported meta-exported