[multimodal] Allow generate and prefill to take move sematics#14643
[multimodal] Allow generate and prefill to take move sematics#14643larryliu0820 merged 1 commit intomainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14643
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 3 Unrelated FailuresAs of commit 0e60d1b with merge base dfa17bc ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
kirklandsign
left a comment
There was a problem hiding this comment.
Sorry I am still not sure about the use case. const vector& is a superset of vector&& ?
If only runner.generate({make_text_input("my prompt"), make_image_input(image_data)}); |
|
We can't do this with |
Can't do this without this PR, we are creating an rvalue and generate doesn't take it. |
As titled