Move tensor layout into exir#14666
Merged
meta-codesync[bot] merged 2 commits intogh/lucylq/114/basefrom Oct 8, 2025
Merged
Conversation
TensorLayout is used by the data_serializer.py abstract class, which is part of //executorch/exir:lib https://www.internalfb.com/code/fbsource/[721dbb621c0b8c460715e5c49bc9c12757e8ccc8]/fbcode/executorch/exir/_serialize/data_serializer.py?lines=6 Shouldn't add extension/flat_tensor:flat_tensor_schema as a dependency to executorch/exir:lib. Note the C++ equivalent is in runtime/core, so I think this makes sense. Differential Revision: [D83504588](https://our.internmc.facebook.com/intern/diff/D83504588/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14666
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit ef193b8 with merge base fb87fa6 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
Contributor
This PR needs a
|
swolchok
approved these changes
Oct 2, 2025
TensorLayout is used by the data_serializer.py abstract class, which is part of //executorch/exir:lib https://www.internalfb.com/code/fbsource/[721dbb621c0b8c460715e5c49bc9c12757e8ccc8]/fbcode/executorch/exir/_serialize/data_serializer.py?lines=6 Shouldn't add extension/flat_tensor:flat_tensor_schema as a dependency to executorch/exir:lib. Note the C++ equivalent is in runtime/core, so I think this makes sense. Differential Revision: [D83504588](https://our.internmc.facebook.com/intern/diff/D83504588/) [ghstack-poisoned]
lucylq
added a commit
that referenced
this pull request
Oct 8, 2025
Pull Request resolved: #14666 TensorLayout is used by the data_serializer.py abstract class, which is part of //executorch/exir:lib https://www.internalfb.com/code/fbsource/[721dbb621c0b8c460715e5c49bc9c12757e8ccc8]/fbcode/executorch/exir/_serialize/data_serializer.py?lines=6 Shouldn't add extension/flat_tensor:flat_tensor_schema as a dependency to executorch/exir:lib. Note the C++ equivalent is in runtime/core, so I think this makes sense. ghstack-source-id: 314887613 @exported-using-ghexport Differential Revision: [D83504588](https://our.internmc.facebook.com/intern/diff/D83504588/)
meta-codesync
bot
merged commit 26a555d
into
gh/lucylq/114/base
220 of 223 checks passed
lucylq
added a commit
that referenced
this pull request
Oct 13, 2025
This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: #14666 by @lucylq ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/lucylq/114/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/lucylq/114/head Merge bot PR base: https://github.com/pytorch/executorch/tree/main Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/lucylq/114/orig Differential Revision: [D83504588](https://our.internmc.facebook.com/intern/diff/D83504588/) @diff-train-skip-merge Co-authored-by: lucylq <lfq@meta.com>
jirioc
pushed a commit
to nxp-upstream/executorch
that referenced
this pull request
Dec 19, 2025
This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: pytorch#14666 by @lucylq ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/lucylq/114/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/lucylq/114/head Merge bot PR base: https://github.com/pytorch/executorch/tree/main Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/lucylq/114/orig Differential Revision: [D83504588](https://our.internmc.facebook.com/intern/diff/D83504588/) @diff-train-skip-merge Co-authored-by: lucylq <lfq@meta.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
TensorLayout is used by the data_serializer.py abstract class, which is part of //executorch/exir:lib
https://www.internalfb.com/code/fbsource/[721dbb621c0b8c460715e5c49bc9c12757e8ccc8]/fbcode/executorch/exir/_serialize/data_serializer.py?lines=6
Shouldn't add extension/flat_tensor:flat_tensor_schema as a dependency to executorch/exir:lib.
Note the C++ equivalent is in runtime/core, so I think this makes sense.
Differential Revision: D83504588