Arm backend: Add correction for floor mode#14776
Merged
zingo merged 9 commits intopytorch:mainfrom Oct 8, 2025
Merged
Conversation
… stable Change-Id: I6e76bab3528c7b05f7710f6a402791c5b682aee3 Signed-off-by: Elena Zhelezina <elena.zhelezina@arm.com>
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14776
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 1 New Failure, 2 Unrelated FailuresAs of commit 5fa4025 with merge base fb87fa6 ( NEW FAILURE - The following job has failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following job failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Collaborator
|
Hi @wwwind this seem to fail for Ethos-U55 |
Change-Id: I4569bbd8f317eb73dab634320ebcf72593adbc93
Collaborator
Author
|
Thank you @zingo I pushed a fix |
Change-Id: I4707f3aa7155a121b0e721f2f344e6c10f330692
Change-Id: I2d89bfecadfc2ec137ecd3c87e728a16b2fc6832
Collaborator
|
fails are unrelated |
zingo
pushed a commit
that referenced
this pull request
Oct 10, 2025
Reverts #14776 due to flaky test results Signed-off-by: Ryan O'Shea <ryan.oshea3@arm.com> cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai
jirioc
pushed a commit
to nxp-upstream/executorch
that referenced
this pull request
Dec 19, 2025
Correct implementation of div.tensor_mode for 'floor' case to make it numerically stable. Signed-off-by: Elena Zhelezina <elena.zhelezina@arm.com>
jirioc
pushed a commit
to nxp-upstream/executorch
that referenced
this pull request
Dec 19, 2025
Reverts pytorch#14776 due to flaky test results Signed-off-by: Ryan O'Shea <ryan.oshea3@arm.com> cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct implementation of div.tensor_mode for 'floor' case to make it numerically stable.
Change-Id: I6e76bab3528c7b05f7710f6a402791c5b682aee3
Signed-off-by: Elena Zhelezina elena.zhelezina@arm.com
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218