Add check for negative index in cpu kernel op_index by Sebastian-Larsson · Pull Request #15366 · pytorch/executorch

Sebastian-Larsson · 2025-10-23T08:44:04Z

Fast path cannot be taken when the index is negative in op_index. It results in a failure in check_fast_path_args. Add a check to check_fast_path_conditions for negative index and return false if one is encountered.

cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai

pytorch-bot · 2025-10-23T08:44:10Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15366

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 9 New Failures, 2 Pending, 4 Unrelated Failures

As of commit b2d4503 with merge base de56c81 ():

NEW FAILURES - The following jobs have failed:

Apple / build-demo-ios / macos-job (gh)
RuntimeError: Command bash /Users/runner/work/_temp/exec_script failed with exit code 65
pull / test-samsung-models-linux / linux-job (gh)
RuntimeError: Command docker exec -t 8bb58912dee40c0f4b73f940c5ac87731203130da9e56c9d4fd359aeba154602 /exec failed with exit code 1
pull / unittest-nxp-neutron / linux-job (gh)
RuntimeError: Command docker exec -t 7d683f56f4e164381b1e5a7d059e13a83a1bdd3ff957549a53b00789d29db19a /exec failed with exit code 1
Test CUDA Builds / export-gemma3-cuda-non-quantized / linux-job (gh)
RuntimeError: Command docker exec -t 2f152424be0018a19ddc48299c4b542c70123d71c535bd1e4ba1ff5494f40f02 /exec failed with exit code 2
Test CUDA Builds / export-gemma3-cuda-quantized-int4-tile-packed / linux-job (gh)
RuntimeError: Command docker exec -t 1f9970702a55030b533cd50deb1939bf253f7bc778009bac1ccc7557d64e0d58 /exec failed with exit code 2
Test CUDA Builds / export-voxtral-cuda-non-quantized / linux-job (gh)
RuntimeError: Command docker exec -t 045e4a838597a0ebba2d9eb6fe626c3621c9ca72c26389acaadb07e117b5eb61 /exec failed with exit code 2
Test CUDA Builds / export-voxtral-cuda-quantized-int4-tile-packed / linux-job (gh)
RuntimeError: Command docker exec -t eadeb3f9f934f64b4b549a1f43e565ec846caf6ee55289b53fb8e5ac1dd6ec8a /exec failed with exit code 2
Test CUDA Builds / export-voxtral-cuda-quantized-int4-weight-only / linux-job (gh)
RuntimeError: Command docker exec -t db2415019ba635cdab3c5e27ac39ae8279c6a92b27d90f4776671af112c07b6f /exec failed with exit code 2
Test Metal Backend / export-voxtral-metal-artifact / macos-job (gh)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 2

FLAKY - The following job failed but was likely due to flakiness present on trunk:

pull / unittest / linux / linux-job (gh) (detected as infra flaky with no log or failing log classifier)

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

pull / unittest / macos / macos-job (gh) (trunk failure)
export/tests/test_target_recipes.py::TestTargetRecipes::test_mv3_model
pull / unittest-editable / linux / linux-job (gh) (trunk failure)
trunk / unittest-release / linux / linux-job (gh) (trunk failure)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

swolchok

looks fine; inline comments are for your consideration and not blocking. However, please also add a test for this behavior (and feel free to @ me for re-review to avoid extra delay).

kernels/portable/cpu/op_index.cpp

Fast path cannot be taken when the index is negative in op_index. It results in a failure in `check_fast_path_args`. Add a check to `check_fast_path_conditions` for negative index and return `false` if one is encountered. Change-Id: I6c3fb1793da9a0831ef41a47dc2ab4423aa38be3 Signed-off-by: Sebastian Larsson <sebastian.larsson@arm.com>

Sebastian-Larsson · 2025-10-24T13:49:32Z

Changed to your suggestions and added tests @swolchok

swolchok · 2025-10-24T15:10:08Z

kernels/test/op_index_test.cpp

+  EXPECT_TENSOR_EQ(ret, expected);
+}
+
+TEST_F(OpIndexTensorOutTest, NegativeIndexSupportedForInt) {


I would prefer to see a templated test, but it's probably not worth blocking on

swolchok · 2025-10-24T15:28:35Z

looks like we have a bunch of infra failures and known flakes in CI. merging.

Fast path was broken for negative indices (see pytorch#15285) Because of this, pytorch#15366 disabled the fast path when the index tensor had negative indices. In this PR we fix the bug, and re-enable the fast path for negative indices. Fixes pytorch#15285 Differential Revision: D86351194

manuelcandales · 2025-11-06T18:18:41Z

@pytorchbot cherry-pick --onto release/1.0 -c critical

@freddan80

Fast path cannot be taken when the index is negative in op_index. It results in a failure in `check_fast_path_args`. Add a check to `check_fast_path_conditions` for negative index and return `false` if one is encountered. cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai Signed-off-by: Sebastian Larsson <sebastian.larsson@arm.com> (cherry picked from commit d6de876)

pytorchbot · 2025-11-06T18:21:05Z

Cherry picking #15366

The cherry pick PR is at #15646 and it is recommended to link a critical cherry pick PR with an issue. The following tracker issues are updated:

[v1.0.1] Release Tracker #15534 (comment)

Details for Dev Infra team

Raised by workflow job

Fast path was broken for negative indices (see #15285) Because of this, #15366 disabled the fast path when the index tensor had negative indices. In this PR we fix the bug, and re-enable the fast path for negative indices. Fixes #15285 Differential Revision: D86351194 (cherry picked from commit 2fa44ea)

Fast path was broken for negative indices (see pytorch#15285) Because of this, pytorch#15366 disabled the fast path when the index tensor had negative indices. In this PR we fix the bug, and re-enable the fast path for negative indices. Fixes pytorch#15285 Differential Revision: D86351194

Fast path was broken for negative indices (see #15285) Because of this, #15366 disabled the fast path when the index tensor had negative indices. In this PR we fix the bug, and re-enable the fast path for negative indices. Fixes #15285 Differential Revision: D86351194 Co-authored-by: Manuel Candales <42380156+manuelcandales@users.noreply.github.com>

@freddan80

Fast path cannot be taken when the index is negative in op_index. It results in a failure in `check_fast_path_args`. Add a check to `check_fast_path_conditions` for negative index and return `false` if one is encountered. cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai Signed-off-by: Sebastian Larsson <sebastian.larsson@arm.com>

Fast path was broken for negative indices (see pytorch#15285) Because of this, pytorch#15366 disabled the fast path when the index tensor had negative indices. In this PR we fix the bug, and re-enable the fast path for negative indices. Fixes pytorch#15285 Differential Revision: D86351194

Sebastian-Larsson requested review from manuelcandales and swolchok as code owners October 23, 2025 08:44

Sebastian-Larsson added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk release notes: arm Changes to the ARM backend delegate labels Oct 23, 2025

meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 23, 2025

Sebastian-Larsson added release notes: ops & kernels Changes to the opset and any new / changed kernel implementations and removed partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: arm Changes to the ARM backend delegate labels Oct 23, 2025

swolchok suggested changes Oct 23, 2025

View reviewed changes

kernels/portable/cpu/op_index.cpp Outdated Show resolved Hide resolved

kernels/portable/cpu/op_index.cpp Show resolved Hide resolved

Sebastian-Larsson force-pushed the negative_index_fix branch from 0315d9b to b2d4503 Compare October 24, 2025 13:48

swolchok approved these changes Oct 24, 2025

View reviewed changes

swolchok merged commit d6de876 into pytorch:main Oct 24, 2025
288 of 301 checks passed

manuelcandales mentioned this pull request Nov 5, 2025

Enable fast path for negative indices #15622

Merged

pytorchbot mentioned this pull request Nov 6, 2025

[v1.0.1] Release Tracker #15534

Closed

pytorchbot mentioned this pull request Nov 6, 2025

Enable fast path for negative indices #15657

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add check for negative index in cpu kernel op_index#15366

Add check for negative index in cpu kernel op_index#15366
swolchok merged 1 commit intopytorch:mainfrom
Sebastian-Larsson:negative_index_fix

Sebastian-Larsson commented Oct 23, 2025 •

edited by pytorch-bot bot

Loading

Uh oh!

pytorch-bot bot commented Oct 23, 2025 •

edited

Loading

Uh oh!

swolchok left a comment

Uh oh!

Uh oh!

Uh oh!

Sebastian-Larsson commented Oct 24, 2025

Uh oh!

swolchok Oct 24, 2025

Uh oh!

swolchok commented Oct 24, 2025

Uh oh!

Uh oh!

manuelcandales commented Nov 6, 2025

Uh oh!

pytorchbot commented Nov 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Sebastian-Larsson commented Oct 23, 2025 • edited by pytorch-bot bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15366

❌ 9 New Failures, 2 Pending, 4 Unrelated Failures

Uh oh!

swolchok left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Sebastian-Larsson commented Oct 24, 2025

Uh oh!

swolchok Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

swolchok commented Oct 24, 2025

Uh oh!

Uh oh!

manuelcandales commented Nov 6, 2025

Uh oh!

pytorchbot commented Nov 6, 2025

Cherry picking #15366

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Sebastian-Larsson commented Oct 23, 2025 •

edited by pytorch-bot bot

Loading

pytorch-bot bot commented Oct 23, 2025 •

edited

Loading