Add bundled IO support to portable executor runner by mansnils · Pull Request #15368 · pytorch/executorch

mansnils · 2025-10-23T11:07:02Z

Executor runner supports both models with/wo bundled io in same path.
To enable bundled IO EXECUTORCH_BUILD_DEVTOOLS and
EXECUTORCH_ENABLE_BUNDLE_IO are required.

Adds tests in Arm backend for testing this/depending on this.
Except for enabling bundle-io for VGF backend where applicable,
some additional resnets model tests are enabled as well.

Avoids narrowing conversion errors in pte_to_header script by switching
char to unsigned char.

cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai

pytorch-bot · 2025-10-23T11:07:06Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15368

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 5 New Failures, 1 Pending, 3 Unrelated Failures

As of commit 29dbed2 with merge base 92bf722 ():

NEW FAILURES - The following jobs have failed:

Apple / build-demo-ios / macos-job (gh)
RuntimeError: Command bash /Users/runner/work/_temp/exec_script failed with exit code 74
pull / unittest / linux / linux-job (gh)
exir/backend/test/test_lowered_backend_module.py::TestBackendAPI::test_emit_nested_lowered_backend_module
pull / unittest / macos / macos-job (gh)
export/tests/test_target_recipes.py::TestTargetRecipes::test_linear_model
trunk / test-models-linux-aarch64 (ic3, portable, linux.arm64.2xlarge) / linux-job (gh)
RuntimeError: Command docker exec -t 7f65d25b1d81312a63a5caed6217754e10d9d31466c8c325a23a6d2584375d22 /exec failed with exit code 1
trunk / test-models-macos-coreml (efficient_sam) / macos-job (gh)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 1

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

mansnils · 2025-10-23T14:19:08Z

Need to either add DEVTOOLS=ON to all cmake recipes that builds the executor runner or use an optional build flag.

JacobSzwejbka · 2025-10-24T04:37:49Z

examples/portable/executor_runner/executor_runner.cpp

  }

+  if (bundle_io) {
+    // With bundled io we can check the result.


This file gets copy pasted a ton as a basic example of a runner. Im pretty resistant to something like this which will tempt people to use it it as a tester. Im already not a huge fan of having the benchmarking stuff in here.

This is now an optional build flag.

JacobSzwejbka · 2025-10-24T04:38:14Z

examples/portable/executor_runner/executor_runner.cpp

 using executorch::runtime::Tag;
 using executorch::runtime::TensorInfo;

+#if defined(ET_BUNDLE_IO_ATOL)


just use gflags to pass these as an arg

JacobSzwejbka · 2025-10-24T04:40:51Z

examples/portable/executor_runner/executor_runner.cpp


-  std::stringstream list_of_input_files(FLAGS_inputs);
-  std::string path;
+  if (!bundle_io) {


are .ptd and bundledProgram mutually exclusive? @lucylq @Gasoonjia.

ptd is only used to pass weights along its not another way to pass inputs to this file afaik

Executor runner supports both models with/wo bundled io in same path. To enable bundled IO EXECUTORCH_BUILD_DEVTOOLS and EXECUTORCH_ENABLE_BUNDLE_IO are required. Adds tests in Arm backend for testing this/depending on this. Except for enabling bundle-io for VGF backend where applicable, some additional resnets model tests are enabled as well. Avoids narrowing conversion errors in pte_to_header script by switching char to unsigned char. Signed-off-by: Måns Nilsson <mans.nilsson@arm.com> Change-Id: Iffdf6c253a57b01abb02758b6ba2d1e3de25e3d8

mansnils · 2025-10-24T06:15:01Z

Need to either add DEVTOOLS=ON to all cmake recipes that builds the executor runner or use an optional build flag.

This comment should be resolved now.
Apologies for force push after your comments @JacobSzwejbka

Change-Id: I91ca1425bc023a37656704b3bae82da26cbd58e4

examples/portable/executor_runner/executor_runner.cpp

Also slightly change condition in order to avoid confusing print, 'Loading inputs from input file(s)' when no files where provided. Change-Id: Icc9c1faa50a1c00e0a6ccf12c85b687af736f6b2

Change-Id: I80148fffc4b25e5470b53b559e184ac08630426a

Change-Id: I2c3e7e25f48d56071861218403941c451baf3a69

JacobSzwejbka · 2025-11-06T01:06:14Z

@mansnils Do you have strong preference to not fork the runner?

We currently have a slight preference in this case to have you fork it rather then add the ifdef stuff. But if you feel really strongly not too we would hear you out.

mansnils · 2025-11-06T07:40:43Z

@mansnils Do you have strong preference to not fork the runner?

We currently have a slight preference in this case to have you fork it rather then add the ifdef stuff. But if you feel really strongly not too we would hear you out.

Yes we really prefer not to fork the runner.

robell · 2025-11-10T12:26:36Z

@mansnils Do you have strong preference to not fork the runner?

We currently have a slight preference in this case to have you fork it rather then add the ifdef stuff. But if you feel really strongly not too we would hear you out.

we're integrated with the Vulkan flows too, so running vulkan or VGF (vulkan extension features) delegates in the same runner and same system configs, sometimes just with a vulkan layer driver, is much preferred.

JacobSzwejbka

Ok that works for me

Summary: Forward fix for pytorch#15368 Reviewed By: metascroy Differential Revision: D87712225

Summary: Forward fix for #15368 Reviewed By: metascroy Differential Revision: D87712225

Executor runner supports both models with/wo bundled io in same path. To enable bundled IO EXECUTORCH_BUILD_DEVTOOLS and EXECUTORCH_ENABLE_BUNDLE_IO are required. Adds tests in Arm backend for testing this/depending on this. Except for enabling bundle-io for VGF backend where applicable, some additional resnets model tests are enabled as well. Avoids narrowing conversion errors in pte_to_header script by switching char to unsigned char. Signed-off-by: Måns Nilsson <mans.nilsson@arm.com> Co-authored-by: Jacob Szwejbka <jakeszwe@meta.com>

Summary: Forward fix for pytorch#15368 Reviewed By: metascroy Differential Revision: D87712225

mansnils requested review from digantdesai, kirklandsign, larryliu0820 and manuelcandales as code owners October 23, 2025 11:07

mansnils added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk release notes: arm Changes to the ARM backend delegate labels Oct 23, 2025

meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 23, 2025

mansnils removed the ciflow/trunk label Oct 23, 2025

mansnils force-pushed the vgf branch from ecfa4b4 to cfa190f Compare October 23, 2025 14:16

JacobSzwejbka requested a review from Gasoonjia October 24, 2025 04:34

JacobSzwejbka requested changes Oct 24, 2025

View reviewed changes

mansnils force-pushed the vgf branch from cfa190f to a1468ae Compare October 24, 2025 06:09

mansnils added the ciflow/trunk label Oct 24, 2025

mansnils added 2 commits October 24, 2025 10:38

Fix buck build error

0d40ba6

Change-Id: I91ca1425bc023a37656704b3bae82da26cbd58e4

Merge remote-tracking branch origin/upstream/main

14e2070

mansnils commented Oct 24, 2025

View reviewed changes

examples/portable/executor_runner/executor_runner.cpp Show resolved Hide resolved

mansnils added 4 commits October 24, 2025 15:29

Fix inputs lifetime issue in executor runner

b024c7c

Also slightly change condition in order to avoid confusing print, 'Loading inputs from input file(s)' when no files where provided. Change-Id: Icc9c1faa50a1c00e0a6ccf12c85b687af736f6b2

Merge remote-tracking branch origin/upstream/main

69b8da5

Provide optional bundled io atol/rtol as parameters

38cacb0

Change-Id: I80148fffc4b25e5470b53b559e184ac08630426a

Correct input handling in executor runner

e7e6105

Change-Id: I2c3e7e25f48d56071861218403941c451baf3a69

JacobSzwejbka approved these changes Nov 20, 2025

View reviewed changes

Merge branch 'main' into vgf

29dbed2

mansnils merged commit 6785032 into pytorch:main Nov 21, 2025
291 of 299 checks passed

cccclai added a commit to cccclai/executorch-1 that referenced this pull request Nov 24, 2025

forward fix PR 15368

8889924

Summary: Forward fix for pytorch#15368 Reviewed By: metascroy Differential Revision: D87712225

cccclai mentioned this pull request Nov 24, 2025

forward fix PR 15368 #15964

Merged

cccclai added a commit that referenced this pull request Nov 24, 2025

forward fix PR 15368 (#15964)

dcff8dc

Summary: Forward fix for #15368 Reviewed By: metascroy Differential Revision: D87712225

jirioc pushed a commit to nxp-upstream/executorch that referenced this pull request Dec 19, 2025

forward fix PR 15368 (pytorch#15964)

ed909ca

Summary: Forward fix for pytorch#15368 Reviewed By: metascroy Differential Revision: D87712225

Conversation

mansnils commented Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15368

❌ 5 New Failures, 1 Pending, 3 Unrelated Failures

Uh oh!

mansnils commented Oct 23, 2025

Uh oh!

JacobSzwejbka Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

mansnils Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

JacobSzwejbka Oct 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mansnils Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

mansnils Oct 30, 2025

Choose a reason for hiding this comment

Uh oh!

JacobSzwejbka Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

mansnils Oct 30, 2025

Choose a reason for hiding this comment

Uh oh!

mansnils commented Oct 24, 2025

Uh oh!

Uh oh!

JacobSzwejbka commented Nov 6, 2025

Uh oh!

mansnils commented Nov 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

robell commented Nov 10, 2025

Uh oh!

JacobSzwejbka left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mansnils commented Oct 23, 2025 •

edited

Loading

pytorch-bot bot commented Oct 23, 2025 •

edited

Loading

JacobSzwejbka Oct 24, 2025 •

edited

Loading

mansnils commented Nov 6, 2025 •

edited

Loading