testing: track the llama export times#15535
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15535
Note: Links to docs will display an error until the docs builds have been completed. ❗ 2 Active SEVsThere are 2 currently active SEVs. If your PR is affected, please view them below:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Hi @mroreo! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
This PR needs a
|
|
@lucylq can you please help re-run the tests |
|
@lucylq can you help re-run this. I added more configurations and updated the times |
|
@lucylq could i get a review for this PR? |
lucylq
left a comment
There was a problem hiding this comment.
Thanks for adding export-time logs, and a script to calculate the aggregate time over multiple GH runs!
0d9f31f to
3630a8e
Compare
|
@lucylq how can i get the tests to pass to get this PR merged? New PRs seem to be merging, and then breaking some tests that are unrelated with this PR |
|
Hi @mroreo sorry for the late response - could you rebase the PR? I will track it and try to merge it. If the test failures are unrelated, we can just click |
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
Summary:
Based on the initial test times the following times were logged for each of the model export times from the following run
Run IDs:
Summary
Fixes #10761
Test Plan:
A script is included in this PR to automatically summarize the model export times based on the run ids. As of right now it is a melted table, but this can easily be grouped by different types using
pandas groupbyif you want to run analyses by the different columns.python scripts/check_model_export_times.py --github_token="YOUR_GITHUB_ACCESS_TOKEN" --run_id 19151256445 19052918428 19052918424 19151256463Once the PR is merged, you can then run this by filter date to get all the model export times after a specific date