Arm backend: Fix bug in ConvertExpandToRepeat pass#15589
Merged
zingo merged 1 commit intopytorch:mainfrom Nov 6, 2025
Merged
Conversation
The pass assumed that if all repeat multiples are one, the op is a no-op. However, it can still change the rank. Signed-off-by: Erik Lundell <erik.lundell@arm.com> Change-Id: I70c311e1fbcbabefc20bc08fa26660e222fb8558
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15589
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 6 Unrelated FailuresAs of commit 62a3a54 with merge base bde6b11 ( NEW FAILURE - The following job has failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
zingo
approved these changes
Nov 5, 2025
Collaborator
|
Fails unrelated, buck2 build should not need to be changed |
abhinaykukkadapu
pushed a commit
to abhinaykukkadapu/executorch
that referenced
this pull request
Nov 6, 2025
The pass assumed that if all repeat multiples are one, the op is a no-op. However, it can still change the rank. Signed-off-by: Erik Lundell <erik.lundell@arm.com>
jirioc
pushed a commit
to nxp-upstream/executorch
that referenced
this pull request
Dec 19, 2025
The pass assumed that if all repeat multiples are one, the op is a no-op. However, it can still change the rank. Signed-off-by: Erik Lundell <erik.lundell@arm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pass assumed that if all repeat multiples are one, the op is a no-op. However, it can still change the rank.
cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai