Revert "Use std::optional"

[metascroy]

Reverts #12707

This causes 1000s of internal CI failures, e.g.,

error: no template named 'optional' in namespace 'torch::executor'; did you mean simply 'optional'?
using optional = torch::executor::optional;
^~~~~~~~~~~~~~~~~~~~~~~~~
optional
note: 'optional' declared here
using ::executorch::aten::optional;

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15612

• 📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 12 Pending

As of commit ece021b with merge base 149e23d ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[github-actions]

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

[JacobSzwejbka]

cc @cyyever I think the root cause of the failures is what I mentioned on your follow up diff of we cant just remove the name "torch::executor::optional" you will need to leave that exposed as an alias for std::optional

[larryliu0820]

cc @cyyever I think the root cause of the failures is what I mentioned on your follow up diff of we cant just remove the name "torch::executor::optional" you will need to leave that exposed as an alias for std::optional

I think you just need to add this line:

#include <executorch/runtime/core/portable_type/optional.h> // @manual

To runtime/core/exec_aten/exec_aten.h

[cyyever]

@JacobSzwejbka Is it better to migrate internal tests to std::optional before changing OSS?